all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager 4/5] fake remote: add jitter to disk/memory values
Date: Fri, 20 Mar 2026 10:25:41 +0100	[thread overview]
Message-ID: <20260320092702.1069143-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260320092702.1069143-1-d.csapak@proxmox.com>

by using the current time and the vmid / index as a factor.

This makes the data look a bit more like 'real' data. This has two
nice effects: we get more realistic values for over the wire
compression (this is useful to measure network bandwidth impact of
theses api calls) and the values get used in some parts of the ui where
we now can observe changes.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 server/src/test_support/fake_remote.rs | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
index 501f2dc6..ae367f68 100644
--- a/server/src/test_support/fake_remote.rs
+++ b/server/src/test_support/fake_remote.rs
@@ -147,23 +147,26 @@ impl pve_api_types::client::PveClient for FakePveClient {
         let cpu = 0.1;
         let maxcpu = 4.0;
 
+        let bytejitter = 2.0 * 1024.0 * 1024.0 * 1024.0 * proxmox_time::epoch_f64().sin();
+
         for _ in 0..self.nr_of_vms {
             vmid += 1;
+            let jitter = ((vmid as f64).sin() * bytejitter).round() as i64;
             result.push(ClusterResource {
                 cgroup_mode: None,
                 content: None,
                 cpu: Some(cpu),
                 diskread: Some(1034),
                 diskwrite: Some(1034),
-                disk: Some(disk),
+                disk: Some(disk.saturating_add_signed(jitter)),
                 hastate: None,
                 id: format!("qemu/{vmid}"),
                 level: Some("".into()),
                 maxcpu: Some(maxcpu),
                 maxdisk: Some(maxdisk),
                 maxmem: Some(maxmem),
-                mem: Some(mem),
-                memhost: Some(memhost),
+                mem: Some(mem.saturating_sub_signed(jitter)),
+                memhost: Some(memhost.saturating_add_signed(jitter)),
                 name: Some(format!("vm-{vmid}")),
                 netin: Some(1034),
                 netout: Some(1034),
@@ -189,11 +192,12 @@ impl pve_api_types::client::PveClient for FakePveClient {
 
         for _ in 0..self.nr_of_cts {
             vmid += 1;
+            let jitter = ((vmid as f64).sin() * bytejitter).round() as i64;
             result.push(ClusterResource {
                 cgroup_mode: None,
                 content: None,
                 cpu: Some(cpu),
-                disk: Some(disk),
+                disk: Some(disk.saturating_add_signed(jitter)),
                 diskread: Some(1034),
                 diskwrite: Some(1034),
                 hastate: None,
@@ -203,7 +207,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
                 maxdisk: Some(maxdisk),
                 maxmem: Some(maxmem),
                 memhost: Some(memhost),
-                mem: Some(mem),
+                mem: Some(mem.saturating_add_signed(jitter)),
                 name: Some(format!("ct-{vmid}")),
                 netin: Some(1034),
                 netout: Some(1034),
@@ -228,11 +232,12 @@ impl pve_api_types::client::PveClient for FakePveClient {
         }
 
         for i in 0..self.nr_of_nodes {
+            let jitter = ((i as f64).sin() * bytejitter).round() as i64;
             result.push(ClusterResource {
                 cgroup_mode: None,
                 content: None,
                 cpu: Some(cpu),
-                disk: Some(disk),
+                disk: Some(disk.saturating_add_signed(jitter)),
                 diskread: None,
                 diskwrite: None,
                 hastate: None,
@@ -241,7 +246,7 @@ impl pve_api_types::client::PveClient for FakePveClient {
                 maxcpu: Some(16.),
                 maxdisk: Some(maxdisk),
                 maxmem: Some(maxmem),
-                mem: Some(mem),
+                mem: Some(mem.saturating_add_signed(jitter)),
                 memhost: None,
                 name: None,
                 netin: None,
@@ -267,11 +272,12 @@ impl pve_api_types::client::PveClient for FakePveClient {
         }
 
         for i in 0..self.nr_of_storages {
+            let jitter = ((i as f64).sin() * bytejitter).round() as i64;
             result.push(ClusterResource {
                 cgroup_mode: None,
                 content: Some(vec![StorageContent::Images, StorageContent::Rootdir]),
                 cpu: None,
-                disk: Some(disk),
+                disk: Some(disk.saturating_add_signed(jitter)),
                 diskread: None,
                 diskwrite: None,
                 hastate: None,
-- 
2.47.3





  parent reply	other threads:[~2026-03-20  9:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20  9:25 [PATCH datacenter-manager 0/5] fix/improve fake-remote code Dominik Csapak
2026-03-20  9:25 ` [PATCH datacenter-manager 1/5] fake remote: update code to implement/use new interfaces Dominik Csapak
2026-03-20  9:25 ` [PATCH datacenter-manager 2/5] fake remote: fix nonsensical values Dominik Csapak
2026-03-20  9:25 ` [PATCH datacenter-manager 3/5] fake remote: factor out cpu/disk/mem values Dominik Csapak
2026-03-20  9:25 ` Dominik Csapak [this message]
2026-03-20  9:25 ` [PATCH datacenter-manager 5/5] fake remotes: make use of ClusterResource more resilient to changes Dominik Csapak
2026-03-20 10:48 ` applied: [PATCH datacenter-manager 0/5] fix/improve fake-remote code Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260320092702.1069143-5-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal