From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager 3/5] fake remote: factor out cpu/disk/mem values
Date: Fri, 20 Mar 2026 10:25:40 +0100 [thread overview]
Message-ID: <20260320092702.1069143-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260320092702.1069143-1-d.csapak@proxmox.com>
makes it much easier to modify all of them at once.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
server/src/test_support/fake_remote.rs | 52 +++++++++++++++-----------
1 file changed, 31 insertions(+), 21 deletions(-)
diff --git a/server/src/test_support/fake_remote.rs b/server/src/test_support/fake_remote.rs
index 21e3a1c9..501f2dc6 100644
--- a/server/src/test_support/fake_remote.rs
+++ b/server/src/test_support/fake_remote.rs
@@ -137,23 +137,33 @@ impl pve_api_types::client::PveClient for FakePveClient {
let mut vmid = 100;
+ let disk: u64 = 42 * 1024 * 1024 * 1024;
+ let maxdisk: u64 = 100 * 1024 * 1024 * 1024;
+
+ let mem: u64 = 3 * 1024 * 1024 * 1024;
+ let memhost: u64 = 4 * 1024 * 1024 * 1024;
+ let maxmem: i64 = 8 * 1024 * 1024 * 1024;
+
+ let cpu = 0.1;
+ let maxcpu = 4.0;
+
for _ in 0..self.nr_of_vms {
vmid += 1;
result.push(ClusterResource {
cgroup_mode: None,
content: None,
- cpu: Some(0.1),
+ cpu: Some(cpu),
diskread: Some(1034),
diskwrite: Some(1034),
- disk: Some(42 * 1024 * 1024 * 1024),
+ disk: Some(disk),
hastate: None,
id: format!("qemu/{vmid}"),
level: Some("".into()),
- maxcpu: Some(4.),
- maxdisk: Some(100 * 1024 * 1024 * 1024),
- maxmem: Some(8 * 1024 * 1024 * 1024),
- mem: Some(3 * 1024 * 1024 * 1024),
- memhost: Some(4 * 1024 * 1024 * 1024),
+ maxcpu: Some(maxcpu),
+ maxdisk: Some(maxdisk),
+ maxmem: Some(maxmem),
+ mem: Some(mem),
+ memhost: Some(memhost),
name: Some(format!("vm-{vmid}")),
netin: Some(1034),
netout: Some(1034),
@@ -182,18 +192,18 @@ impl pve_api_types::client::PveClient for FakePveClient {
result.push(ClusterResource {
cgroup_mode: None,
content: None,
- cpu: Some(0.1),
- disk: Some(42 * 1024 * 1024 * 1024),
+ cpu: Some(cpu),
+ disk: Some(disk),
diskread: Some(1034),
diskwrite: Some(1034),
hastate: None,
id: format!("lxc/{vmid}"),
level: Some("".into()),
- maxcpu: Some(4.),
- maxdisk: Some(100 * 1024 * 1024 * 1024),
- maxmem: Some(8 * 1024 * 1024 * 1024),
- memhost: Some(4 * 1024 * 1024 * 1024),
- mem: Some(3 * 1024 * 1024 * 1024),
+ maxcpu: Some(maxcpu),
+ maxdisk: Some(maxdisk),
+ maxmem: Some(maxmem),
+ memhost: Some(memhost),
+ mem: Some(mem),
name: Some(format!("ct-{vmid}")),
netin: Some(1034),
netout: Some(1034),
@@ -221,17 +231,17 @@ impl pve_api_types::client::PveClient for FakePveClient {
result.push(ClusterResource {
cgroup_mode: None,
content: None,
- cpu: Some(0.1),
- disk: Some(42 * 1024 * 1024 * 1024),
+ cpu: Some(cpu),
+ disk: Some(disk),
diskread: None,
diskwrite: None,
hastate: None,
id: format!("node/node-{i}"),
level: Some("".into()),
maxcpu: Some(16.),
- maxdisk: Some(100 * 1024 * 1024 * 1024),
- maxmem: Some(8 * 1024 * 1024 * 1024),
- mem: Some(3 * 1024 * 1024 * 1024),
+ maxdisk: Some(maxdisk),
+ maxmem: Some(maxmem),
+ mem: Some(mem),
memhost: None,
name: None,
netin: None,
@@ -261,14 +271,14 @@ impl pve_api_types::client::PveClient for FakePveClient {
cgroup_mode: None,
content: Some(vec![StorageContent::Images, StorageContent::Rootdir]),
cpu: None,
- disk: Some(42 * 1024 * 1024 * 1024),
+ disk: Some(disk),
diskread: None,
diskwrite: None,
hastate: None,
id: format!("storage/node-0/storage-{i}"),
level: None,
maxcpu: None,
- maxdisk: Some(100 * 1024 * 1024 * 1024),
+ maxdisk: Some(maxdisk),
maxmem: None,
mem: None,
memhost: None,
--
2.47.3
next prev parent reply other threads:[~2026-03-20 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 9:25 [PATCH datacenter-manager 0/5] fix/improve fake-remote code Dominik Csapak
2026-03-20 9:25 ` [PATCH datacenter-manager 1/5] fake remote: update code to implement/use new interfaces Dominik Csapak
2026-03-20 9:25 ` [PATCH datacenter-manager 2/5] fake remote: fix nonsensical values Dominik Csapak
2026-03-20 9:25 ` Dominik Csapak [this message]
2026-03-20 9:25 ` [PATCH datacenter-manager 4/5] fake remote: add jitter to disk/memory values Dominik Csapak
2026-03-20 9:25 ` [PATCH datacenter-manager 5/5] fake remotes: make use of ClusterResource more resilient to changes Dominik Csapak
2026-03-20 10:48 ` applied: [PATCH datacenter-manager 0/5] fix/improve fake-remote code Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320092702.1069143-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.