all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 2/5] api: config: expose fstrim schedule for datastores
Date: Thu, 19 Mar 2026 15:36:46 +0100	[thread overview]
Message-ID: <20260319143649.681937-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260319143649.681937-1-c.ebner@proxmox.com>

Allows to create/edit/delete schedules to run fstrim on datastore's
backing filesystems.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/api2/config/datastore.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
index f845fe2d0..b10b7fb0a 100644
--- a/src/api2/config/datastore.rs
+++ b/src/api2/config/datastore.rs
@@ -412,6 +412,8 @@ pub enum DeletableProperty {
     GcSchedule,
     /// Delete the prune job schedule.
     PruneSchedule,
+    /// Delete the fstrim job schedule.
+    FstrimSchedule,
     /// Delete the keep-last property
     KeepLast,
     /// Delete the keep-hourly property
@@ -498,6 +500,9 @@ pub fn update_datastore(
                 DeletableProperty::PruneSchedule => {
                     data.prune_schedule = None;
                 }
+                DeletableProperty::FstrimSchedule => {
+                    data.fstrim_schedule = None;
+                }
                 DeletableProperty::KeepLast => {
                     data.keep.keep_last = None;
                 }
@@ -553,6 +558,10 @@ pub fn update_datastore(
         data.gc_schedule = update.gc_schedule;
     }
 
+    if update.fstrim_schedule.is_some() {
+        data.fstrim_schedule = update.fstrim_schedule;
+    }
+
     macro_rules! prune_disabled {
         ($(($param:literal, $($member:tt)+)),+) => {
             $(
-- 
2.47.3





  parent reply	other threads:[~2026-03-19 14:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 14:36 [RFC proxmox{,-backup} 0/6] add scheduled fstrim job for datastore's backing filesystems Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox 1/1] pbs-api-types: define fstrim schedule on datastore config Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox-backup 1/5] tools: add helper to run fstrim command on path or mountpoint Christian Ebner
2026-03-19 14:36 ` Christian Ebner [this message]
2026-03-19 14:36 ` [PATCH proxmox-backup 3/5] bin: proxy: periodically schedule fstrim on datastore's filesystems Christian Ebner
2026-03-19 15:02   ` Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox-backup 4/5] ui: expose per-datastore fstrim job schedule Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox-backup 5/5] api: set default fstrim schedule on datastore create Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319143649.681937-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal