From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH proxmox v2 04/25] parallel-handler: add simple unit-test suite
Date: Thu, 19 Mar 2026 10:45:24 +0100 [thread overview]
Message-ID: <20260319094617.169594-5-l.wagner@proxmox.com> (raw)
In-Reply-To: <20260319094617.169594-1-l.wagner@proxmox.com>
Add a simple test suite to the new proxmox-parallel-handler crate to
avoid any future regressions.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
proxmox-parallel-handler/src/lib.rs | 73 +++++++++++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/proxmox-parallel-handler/src/lib.rs b/proxmox-parallel-handler/src/lib.rs
index 38f6a48a..91dac17d 100644
--- a/proxmox-parallel-handler/src/lib.rs
+++ b/proxmox-parallel-handler/src/lib.rs
@@ -269,3 +269,76 @@ impl<I> Drop for ParallelHandler<I> {
}
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+ use std::sync::atomic::{AtomicUsize, Ordering};
+
+ #[test]
+ fn test_send_on_pool() {
+ let count = Arc::new(AtomicUsize::new(0));
+ let count_clone = Arc::clone(&count);
+
+ let pool = ParallelHandler::new("ok", 2, move |_: u32| {
+ count_clone.fetch_add(1, Ordering::Relaxed);
+ Ok(())
+ });
+
+ for i in 0..10 {
+ pool.send(i).unwrap();
+ }
+
+ pool.complete().unwrap();
+ assert_eq!(count.load(Ordering::Relaxed), 10);
+ }
+
+ #[test]
+ fn test_send_on_handle() {
+ let count = Arc::new(AtomicUsize::new(0));
+ let count_clone = Arc::clone(&count);
+
+ let pool = ParallelHandler::new("chan", 2, move |_: u32| {
+ count_clone.fetch_add(1, Ordering::Relaxed);
+ Ok(())
+ });
+
+ let handle = pool.channel();
+ for i in 0..5 {
+ handle.send(i).unwrap();
+ }
+ drop(handle);
+
+ pool.complete().unwrap();
+ assert_eq!(count.load(Ordering::Relaxed), 5);
+ }
+
+ #[test]
+ fn handler_error_is_propagated_on_complete() {
+ let pool = ParallelHandler::new("fail", 1, |_: u32| {
+ anyhow::bail!("boom");
+ });
+
+ pool.send(1).unwrap();
+ let err = pool.complete().unwrap_err();
+
+ match err {
+ Error::HandlerFailed(msg) => assert!(msg.contains("boom")),
+ _ => panic!("invalid error variant"),
+ }
+ }
+
+ #[test]
+ fn thread_panic_is_reported_on_complete() {
+ let pool = ParallelHandler::new("panic", 1, |_: u32| -> Result<(), anyhow::Error> {
+ panic!("boom");
+ });
+
+ pool.send(1).unwrap();
+ let err = pool.complete().unwrap_err();
+ match err {
+ Error::ThreadPanicked { message, .. } => assert!(message.unwrap().contains("boom")),
+ _ => panic!("invalid error variant"),
+ }
+ }
+}
--
2.47.3
next prev parent reply other threads:[~2026-03-19 9:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 9:45 [PATCH datacenter-manager/proxmox{,-backup,-yew-comp} v2 00/25] metric collection for the PDM host Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 01/25] parallel-handler: import code from Proxmox Backup Server Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 02/25] parallel-handler: introduce custom error type Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 03/25] parallel-handler: add documentation Lukas Wagner
2026-03-19 9:45 ` Lukas Wagner [this message]
2026-03-19 9:45 ` [PATCH proxmox v2 06/25] disks: fix typo in `initialize_gpt_disk` Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 07/25] disks: add parts of gather_disk_stats from PBS Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 08/25] disks: gate api macro behind 'api-types' feature Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 09/25] disks: clippy: collapse if-let chains where possible Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 10/25] procfs: add helpers for querying pressure stall information Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox v2 11/25] time: use u64 parse helper from nom Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox-backup v2 12/25] tools: move ParallelHandler to new proxmox-parallel-handler crate Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox-backup v2 13/25] tools: replace disks module with proxmox-disks Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox-backup v2 14/25] metric collection: use blockdev_stat_for_path from proxmox_disks Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox-yew-comp v2 15/25] node status panel: add `children` property Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox-yew-comp v2 16/25] RRDGrid: fix size observer by attaching node reference to rendered container Lukas Wagner
2026-03-19 9:45 ` [PATCH proxmox-yew-comp v2 17/25] RRDGrid: add padding and increase gap between elements Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 18/25] metric collection: clarify naming for remote metric collection Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 19/25] metric collection: fix minor typo in error message Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 20/25] metric collection: collect PDM host metrics in a new collection task Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 21/25] api: fix /nodes/localhost/rrddata endpoint Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 22/25] pdm: node rrd data: rename 'total-time' to 'metric-collection-total-time' Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 23/25] pdm-api-types: add PDM host metric fields Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 24/25] ui: node status: add RRD graphs for PDM host metrics Lukas Wagner
2026-03-19 9:45 ` [PATCH datacenter-manager v2 25/25] ui: lxc/qemu/node: use RRD value render helpers Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319094617.169594-5-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.