all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Stefan Mayr <stefan@mayr-stefan.de>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: applied:  [PATCH pmg-api v2 3/4] Fix #7175: replace timezone handling with systemd timedatectl
Date: Mon, 16 Mar 2026 11:10:42 +0100	[thread overview]
Message-ID: <20260316111042.2eda9df1@rosa.proxmox.com> (raw)
In-Reply-To: <20260125210151.1151-4-stefan@mayr-stefan.de>

applied the patch with an updated versioned dependency on
libpve-common-perl

Thanks!

On Sun, 25 Jan 2026 22:01:50 +0100
Stefan Mayr <stefan@mayr-stefan.de> wrote:

> Usage of /etc/timezone is deprecated. The tzdata maintainers recommend
> switching to timedatectl.
> 
> This changes the use of INotify to the Systemd module for timezone
> settings.
> 
> Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Suggested-by: Maximiliano Sandroval <m.sandoval@proxmox.com>
> Signed-off-by: Stefan Mayr <stefan@mayr-stefan.de>
> ---
>  src/PMG/API2/Nodes.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PMG/API2/Nodes.pm b/src/PMG/API2/Nodes.pm
> index 3479d64..66c4c3b 100644
> --- a/src/PMG/API2/Nodes.pm
> +++ b/src/PMG/API2/Nodes.pm
> @@ -662,7 +662,7 @@ __PACKAGE__->register_method({
>          my $ctime = time();
>          my $ltime = timegm_nocheck(localtime($ctime));
>          my $res = {
> -            timezone => PVE::INotify::read_file('timezone'),
> +            timezone => PVE::Systemd::get_timezone(),
>              time => time(),
>              localtime => $ltime,
>          };
> @@ -693,7 +693,7 @@ __PACKAGE__->register_method({
>      code => sub {
>          my ($param) = @_;
>  
> -        PVE::INotify::write_file('timezone', $param->{timezone});
> +        PVE::Systemd::set_timezone($param->{timezone});
>  
>          return undef;
>      },





  reply	other threads:[~2026-03-16 10:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-25 21:01 [pve-devel] [PATCH common, container, manager and pmg-api v2 0/4] " Stefan Mayr
2026-01-25 21:01 ` [pve-devel] [PATCH manager v2 1/4] " Stefan Mayr
2026-03-16  9:36   ` applied: " Fabian Grünbichler
2026-01-25 21:01 ` [pve-devel] [PATCH container v2 2/4] " Stefan Mayr
2026-03-16  9:36   ` applied: " Fabian Grünbichler
2026-01-25 21:01 ` [pve-devel] [PATCH pmg-api v2 3/4] " Stefan Mayr
2026-03-16 10:10   ` Stoiko Ivanov [this message]
2026-01-25 21:01 ` [pve-devel] [PATCH common v2 4/4] " Stefan Mayr
2026-02-18 19:53 ` [pve-devel] [PATCH common, container, manager and pmg-api v2 0/4] " Stefan Mayr
2026-02-19  8:13   ` Fabian Grünbichler
2026-02-20 11:48 ` Stoiko Ivanov
2026-02-22 11:02   ` [PATCH common v3 0/2] " Stefan Mayr
2026-02-23 10:02     ` Stoiko Ivanov
2026-02-22 11:02   ` [PATCH common v3 1/2] " Stefan Mayr
2026-02-25 10:32     ` partially-applied: " Fabian Grünbichler
2026-02-22 11:02   ` [PATCH common v3 2/2] " Stefan Mayr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316111042.2eda9df1@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=stefan@mayr-stefan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal