all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC PATCH qemu-server 3/4] introduce sub 'activate_current_vm_volumes'
Date: Fri, 13 Mar 2026 14:12:05 +0100	[thread overview]
Message-ID: <20260313131206.277195-4-d.herzig@proxmox.com> (raw)
In-Reply-To: <20260313131206.277195-1-d.herzig@proxmox.com>

Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
 src/PVE/QemuServer.pm | 54 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 09e7a19b..a7b98e01 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -6068,6 +6068,60 @@ sub get_current_vm_volumes {
     return $volumes;
 }
 
+=head3 activate_current_vm_volumes($storecfg, $conf, $vmid [, $statefile_volume])
+Activates VM volumes (With -blockdev, it is necessary to activate the volumes
+before generating the command line).
+
+NOTE: If $drive->{dismissable} is specified for a CD-ROM, C<$conf> may change.
+If $drive->{file} is unavailable, $drive->{file} will be set to 'none', and
+the entries $drive->{size} and $drive->{format} will be deleted.
+This will be written out to C<$conf>.
+
+=cut
+sub activate_current_vm_volumes {
+    my ($storecfg, $conf, $vmid, $statefile_volume, $storage_hints) = @_;
+    my $volumes_to_be_activated = [];
+    my $activated_volumes = [];
+
+    if ($statefile_volume) {
+	push $volumes_to_be_activated->@*, $statefile_volume;
+    }
+    PVE::QemuConfig->foreach_volume_full(
+        $conf,
+        { extra_keys => ['vmstate'] },
+        sub {
+            my ($ds, $drive) = @_;
+	    my $volid = $drive->{file};
+	    if (PVE::Storage::parse_volume_id($volid, 1)) {
+		check_volume_storage_type($storecfg, $volid);
+		if ($drive->{dismissable}) {
+		    eval { PVE::Storage::activate_volumes($storecfg, [$volid]) };
+		    if ($@) {
+			log_warn($@);
+			log_warn("removing dismissable CD-ROM from VM configuration: ". $volid);
+			$drive->{file} = "none";
+			delete $drive->{size};
+			delete $drive->{format};
+			$conf->{$ds} = print_drive($drive);
+			PVE::QemuConfig->write_config($vmid, $conf);
+		    } else {
+			push $activated_volumes->@*, $volid;
+		    }
+		} else {
+		    push $volumes_to_be_activated->@*, $volid;
+		}
+	    }
+	}
+    );
+    eval { PVE::Storage::activate_volumes($storecfg, $volumes_to_be_activated, undef, $storage_hints) };
+    if ($@) {
+	die $@;
+    } else {
+	push $activated_volumes->@*, $volumes_to_be_activated;
+    }
+    return $activated_volumes;
+}
+
 sub cleanup_pci_devices {
     my ($vmid, $conf) = @_;
 
-- 
2.47.3




  parent reply	other threads:[~2026-03-13 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 13:12 [RFC PATCH qemu-server 0/4] allow VMs to start with missing CD-ROM Daniel Herzig
2026-03-13 13:12 ` [RFC PATCH qemu-server 1/4] drive: Introduce parameter to mark CD-ROM as dissmissable Daniel Herzig
2026-03-13 13:12 ` [RFC PATCH qemu-server 2/4] drive: ignore 'dismissable' parameter for everything but CD-ROMs Daniel Herzig
2026-03-13 13:12 ` Daniel Herzig [this message]
2026-03-13 13:12 ` [RFC PATCH qemu-server 4/4] integrate new sub 'activate_current_vm_volumes' Daniel Herzig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260313131206.277195-4-d.herzig@proxmox.com \
    --to=d.herzig@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal