all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 3/3] memory: fix unit in heuristic comment
Date: Thu, 12 Mar 2026 15:54:22 +0100	[thread overview]
Message-ID: <20260312145423.434537-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260312145423.434537-1-m.sandoval@proxmox.com>

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/QemuServer/Memory.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer/Memory.pm b/src/PVE/QemuServer/Memory.pm
index f21b0b8d..4ccb89ea 100644
--- a/src/PVE/QemuServer/Memory.pm
+++ b/src/PVE/QemuServer/Memory.pm
@@ -151,7 +151,7 @@ my sub get_max_mem {
 
     $bits = $bits & ~1; # round down to nearest even as limit is lower with odd bit sizes
 
-    # heuristic: remove 20 bits to get MB and half that as QEMU needs some overhead
+    # heuristic: remove 20 bits to get MiB and half that as QEMU needs some overhead
     my $bits_to_max_mem = int(1 << ($bits - 21));
 
     return $bits_to_max_mem > 4 * 1024 * 1024 ? 4 * 1024 * 1024 : $bits_to_max_mem;
-- 
2.47.3





      parent reply	other threads:[~2026-03-12 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 14:54 [PATCH qemu-server v2 0/3] memory: add verbose_description to NUMA policy Maximiliano Sandoval
2026-03-12 14:54 ` [PATCH qemu-server v2 1/3] " Maximiliano Sandoval
2026-03-12 14:54 ` [PATCH qemu-server v2 2/3] memory: add default NUMA allocation policy Maximiliano Sandoval
2026-03-12 14:54 ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312145423.434537-4-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal