all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v4 7/7] ui: add move namespace action
Date: Wed, 11 Mar 2026 16:13:15 +0100	[thread overview]
Message-ID: <20260311151315.133637-8-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260311151315.133637-1-h.laimer@proxmox.com>

When moving a namespace, exclude the source namespace and its subtree
from the 'New Parent' selector.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/Makefile                  |  1 +
 www/datastore/Content.js      |  1 -
 www/form/NamespaceSelector.js | 11 +++++
 www/window/NamespaceMove.js   | 79 +++++++++++++++++++++++++++++++++++
 4 files changed, 91 insertions(+), 1 deletion(-)
 create mode 100644 www/window/NamespaceMove.js

diff --git a/www/Makefile b/www/Makefile
index db775b64..9452879a 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -80,6 +80,7 @@ JSSRC=							\
 	window/GroupMove.js				\
 	window/DataStoreEdit.js				\
 	window/NamespaceEdit.js				\
+	window/NamespaceMove.js				\
 	window/MaintenanceOptions.js			\
 	window/NotesEdit.js				\
 	window/RemoteEdit.js				\
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index ccd48616..fb0858e9 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -678,7 +678,6 @@ Ext.define('PBS.DataStoreContent', {
             }
         },
 
-
         forgetGroup: function (data) {
             let me = this;
             let view = me.getView();
diff --git a/www/form/NamespaceSelector.js b/www/form/NamespaceSelector.js
index ddf68254..d349b568 100644
--- a/www/form/NamespaceSelector.js
+++ b/www/form/NamespaceSelector.js
@@ -90,6 +90,17 @@ Ext.define('PBS.form.NamespaceSelector', {
             },
         });
 
+        if (me.excludeNs) {
+            me.store.addFilter(
+                new Ext.util.Filter({
+                    filterFn: (rec) => {
+                        let ns = rec.data.ns;
+                        return ns !== me.excludeNs && !ns.startsWith(`${me.excludeNs}/`);
+                    },
+                }),
+            );
+        }
+
         me.callParent();
     },
 });
diff --git a/www/window/NamespaceMove.js b/www/window/NamespaceMove.js
new file mode 100644
index 00000000..415d509d
--- /dev/null
+++ b/www/window/NamespaceMove.js
@@ -0,0 +1,79 @@
+Ext.define('PBS.window.NamespaceMove', {
+    extend: 'Proxmox.window.Edit',
+    alias: 'widget.pbsNamespaceMove',
+    mixins: ['Proxmox.Mixin.CBind'],
+
+    onlineHelp: 'storage-namespaces',
+
+    submitText: gettext('Move'),
+    isCreate: true,
+    showTaskViewer: true,
+
+    cbind: {
+        url: '/api2/extjs/admin/datastore/{datastore}/namespace',
+        title: (get) => Ext.String.format(gettext("Move Namespace '{0}'"), get('namespace')),
+    },
+    method: 'PUT',
+
+    width: 450,
+    fieldDefaults: {
+        labelWidth: 120,
+    },
+
+    cbindData: function (initialConfig) {
+        let ns = initialConfig.namespace ?? '';
+        let parts = ns.split('/');
+        return { nsName: parts[parts.length - 1] };
+    },
+
+    // Returns the new-ns path that was submitted, for use by the caller after success.
+    getNewNamespace: function () {
+        let me = this;
+        let parent = me.down('[name=parent]').getValue() || '';
+        let name = me.down('[name=name]').getValue();
+        return parent ? `${parent}/${name}` : name;
+    },
+
+    items: {
+        xtype: 'inputpanel',
+        onGetValues: function (values) {
+            let parent = values.parent || '';
+            let newNs = parent ? `${parent}/${values.name}` : values.name;
+            return {
+                ns: this.up('window').namespace,
+                'new-ns': newNs,
+            };
+        },
+        items: [
+            {
+                xtype: 'displayfield',
+                fieldLabel: gettext('Namespace'),
+                cbind: {
+                    value: '{namespace}',
+                },
+            },
+            {
+                xtype: 'pbsNamespaceSelector',
+                name: 'parent',
+                fieldLabel: gettext('New Parent'),
+                allowBlank: true,
+                cbind: {
+                    datastore: '{datastore}',
+                    excludeNs: '{namespace}',
+                },
+            },
+            {
+                xtype: 'proxmoxtextfield',
+                name: 'name',
+                fieldLabel: gettext('New Name'),
+                allowBlank: false,
+                maxLength: 31,
+                regex: PBS.Utils.SAFE_ID_RE,
+                regexText: gettext("Only alpha numerical, '_' and '-' (if not at start) allowed"),
+                cbind: {
+                    value: '{nsName}',
+                },
+            },
+        ],
+    },
+});
-- 
2.47.3





  parent reply	other threads:[~2026-03-11 15:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 15:13 [PATCH proxmox-backup v4 0/7] fixes #6195: add support for moving groups and namespaces Hannes Laimer
2026-03-11 15:13 ` [PATCH proxmox-backup v4 1/7] datastore: add namespace-level locking Hannes Laimer
2026-03-12 15:43   ` Christian Ebner
2026-03-13  7:40     ` Hannes Laimer
2026-03-13  7:56       ` Christian Ebner
2026-03-11 15:13 ` [PATCH proxmox-backup v4 2/7] datastore: add move_group Hannes Laimer
2026-03-12 16:08   ` Christian Ebner
2026-03-13  7:28     ` Hannes Laimer
2026-03-13  7:52       ` Christian Ebner
2026-03-11 15:13 ` [PATCH proxmox-backup v4 3/7] datastore: add move_namespace Hannes Laimer
2026-03-11 15:13 ` [PATCH proxmox-backup v4 4/7] api: add PUT endpoint for move_group Hannes Laimer
2026-03-12 16:17   ` Christian Ebner
2026-03-11 15:13 ` [PATCH proxmox-backup v4 5/7] api: add PUT endpoint for move_namespace Hannes Laimer
2026-03-12 16:19   ` Christian Ebner
2026-03-11 15:13 ` [PATCH proxmox-backup v4 6/7] ui: add move group action Hannes Laimer
2026-03-11 15:13 ` Hannes Laimer [this message]
2026-03-12 16:21 ` [PATCH proxmox-backup v4 0/7] fixes #6195: add support for moving groups and namespaces Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311151315.133637-8-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal