all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ha-manager 0/2] fix #7399: check if required rule props are set
Date: Wed, 11 Mar 2026 13:49:34 +0100	[thread overview]
Message-ID: <20260311125008.271334-1-d.kral@proxmox.com> (raw)

The API endpoints allow users to set empty 'nodes' and 'resources'
properties for HA rules, which are not handled by the api schema
verification nor the api handlers themselves.

PATCH 1 fixes the

    got unexpected error - cannot lookup undefined type! at
    /usr/share/perl5/PVE/HA/Config.pm line 232.

error message for existing configs with invalid sections, which prevents
the CRM from doing any other progress. It will only keep logging the
hint that a section misses a required option.

PATCH 2 prevents users from passing empty strings for the 'nodes' and
'resources' parameters, which are catched before these are written to
the rules config itself.

A more general solution is proposed in [0], which fixes this behavior in
PVE::SectionConfig itself.

[0] https://lore.proxmox.com/pve-devel/20260311122659.250421-1-d.kral@proxmox.com/

Daniel Kral (2):
  rules: ensure rule is defined and has type in set_rule_defaults
  api: rules: check for non-empty nodes and resources properties

 src/PVE/API2/HA/Rules.pm | 16 ++++++++++------
 src/PVE/HA/Rules.pm      |  3 ++-
 2 files changed, 12 insertions(+), 7 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-03-11 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 12:49 Daniel Kral [this message]
2026-03-11 12:49 ` [PATCH ha-manager 1/2] rules: ensure rule is defined and has type in set_rule_defaults Daniel Kral
2026-03-12  9:49   ` Fiona Ebner
2026-03-11 12:49 ` [PATCH ha-manager 2/2] api: rules: check for non-empty nodes and resources properties Daniel Kral
2026-03-11 17:06 ` applied: [PATCH ha-manager 0/2] fix #7399: check if required rule props are set Thomas Lamprecht
2026-03-12  8:43   ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311125008.271334-1-d.kral@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal