all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v2 1/3] datastore: introduce helper to get store's backend type
Date: Wed, 11 Mar 2026 13:04:59 +0100	[thread overview]
Message-ID: <20260311120501.536269-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260311120501.536269-1-c.ebner@proxmox.com>

In contrast to the pre-existing backend() helper, this newly
introduced backend_type() helper allows to determine a datastores
backend without already instantiating the s3 client in case the
backend is s3.

This will allow to fetch the backend type for the datastore's status
api without having to re-lookup the config.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index af883c467..15a34f376 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -403,7 +403,7 @@ impl DataStore {
 
     /// Get the backend for this datastore based on it's configuration
     pub fn backend(&self) -> Result<DatastoreBackend, Error> {
-        let backend_type = match self.inner.backend_config.ty.unwrap_or_default() {
+        let backend = match self.backend_type() {
             DatastoreBackendType::Filesystem => DatastoreBackend::Filesystem,
             DatastoreBackendType::S3 => {
                 let s3_client_id = self
@@ -439,7 +439,11 @@ impl DataStore {
             }
         };
 
-        Ok(backend_type)
+        Ok(backend)
+    }
+
+    pub fn backend_type(&self) -> DatastoreBackendType {
+        self.inner.backend_config.ty.unwrap_or_default()
     }
 
     pub fn cache(&self) -> Option<&LocalDatastoreLruCache> {
-- 
2.47.3





  parent reply	other threads:[~2026-03-11 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 12:04 [PATCH proxmox{,-backup} v2 0/4] switch local storage usage titles based on datastore backend Christian Ebner
2026-03-11 12:04 ` [PATCH proxmox v2 1/1] pbs-api-types: add backend type to datastore's status items Christian Ebner
2026-03-11 12:04 ` Christian Ebner [this message]
2026-03-11 12:05 ` [PATCH proxmox-backup v2 2/3] api: status/datastore: expose backend type in datastore status/list Christian Ebner
2026-03-11 12:05 ` [PATCH proxmox-backup v2 3/3] ui: Set datastore usage related titles based on backend Christian Ebner
2026-03-11 15:01 ` applied-series: [PATCH proxmox{,-backup} v2 0/4] switch local storage usage titles based on datastore backend Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311120501.536269-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal