all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v2 1/1] pbs-api-types: add backend type to datastore's status items
Date: Wed, 11 Mar 2026 13:04:58 +0100	[thread overview]
Message-ID: <20260311120501.536269-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260311120501.536269-1-c.ebner@proxmox.com>

Add the backend type to both, the datastore status and the datastore
status list item. This allows to interpret the provided data based
on the backend without the need to determine the backend type by
additional api calls.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-api-types/src/datastore.rs | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index b4e7ccf5..3e87eaaa 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -1677,6 +1677,9 @@ pub struct GarbageCollectionJobStatus {
             type: Counts,
             optional: true,
         },
+        "backend-type": {
+            type: DatastoreBackendType,
+        },
     },
 )]
 #[derive(Serialize, Deserialize)]
@@ -1695,6 +1698,9 @@ pub struct DataStoreStatus {
     /// Group/Snapshot counts
     #[serde(skip_serializing_if = "Option::is_none")]
     pub counts: Option<Counts>,
+    /// Datastore backend type
+    #[serde(default)]
+    pub backend_type: DatastoreBackendType,
 }
 
 #[api(
@@ -1713,6 +1719,9 @@ pub struct DataStoreStatus {
                 description: "The usage of a time in the past. Either null or between 0.0 and 1.0.",
             }
         },
+        "backend-type": {
+            type: DatastoreBackendType,
+        },
      },
 )]
 #[derive(Serialize, Deserialize, Clone, PartialEq)]
@@ -1752,10 +1761,18 @@ pub struct DataStoreStatusListItem {
     /// Status of last GC
     #[serde(skip_serializing_if = "Option::is_none")]
     pub gc_status: Option<GarbageCollectionStatus>,
+    /// Datastore backend type
+    #[serde(default)]
+    pub backend_type: DatastoreBackendType,
 }
 
 impl DataStoreStatusListItem {
-    pub fn empty(store: &str, err: Option<String>, mount_status: DataStoreMountStatus) -> Self {
+    pub fn empty(
+        store: &str,
+        err: Option<String>,
+        mount_status: DataStoreMountStatus,
+        backend_type: DatastoreBackendType,
+    ) -> Self {
         DataStoreStatusListItem {
             store: store.to_owned(),
             total: None,
@@ -1768,6 +1785,7 @@ impl DataStoreStatusListItem {
             estimated_full_date: None,
             error: err,
             gc_status: None,
+            backend_type,
         }
     }
 }
-- 
2.47.3





  reply	other threads:[~2026-03-11 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 12:04 [PATCH proxmox{,-backup} v2 0/4] switch local storage usage titles based on datastore backend Christian Ebner
2026-03-11 12:04 ` Christian Ebner [this message]
2026-03-11 12:04 ` [PATCH proxmox-backup v2 1/3] datastore: introduce helper to get store's backend type Christian Ebner
2026-03-11 12:05 ` [PATCH proxmox-backup v2 2/3] api: status/datastore: expose backend type in datastore status/list Christian Ebner
2026-03-11 12:05 ` [PATCH proxmox-backup v2 3/3] ui: Set datastore usage related titles based on backend Christian Ebner
2026-03-11 15:01 ` applied-series: [PATCH proxmox{,-backup} v2 0/4] switch local storage usage titles based on datastore backend Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311120501.536269-2-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal