all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage v2 05/11] lvm plugin: snapshot delete: clarify comment about using commit
Date: Wed, 11 Mar 2026 10:44:44 +0100	[thread overview]
Message-ID: <20260311094506.22359-6-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com>

The volume size of the child might actually be bigger if there was a
resize. However, in terms of actual data that needs to be merged, the
child is usually smaller.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/LVMPlugin.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index e58cd33..d34dfef 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1201,7 +1201,8 @@ sub volume_snapshot_delete {
     my $childvolname = $snapshots->{$childsnap}->{volname};
 
     my $err = undef;
-    #if first snapshot,as it should be bigger,  we merge child, and rename the snapshot to child
+    # if first snapshot, as it should be bigger in terms of actual data, we merge child, and rename
+    # the snapshot to child
     if (!$parentsnap) {
         print "$volname: deleting snapshot '$snap' by commiting snapshot '$childsnap'\n";
         print "running 'qemu-img commit $childpath'\n";
-- 
2.47.3





  parent reply	other threads:[~2026-03-11  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  9:44 [PATCH-SERIES storage/qemu-server v2 00/11] fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 01/11] plugin: document volume_snapshot_info() method Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 02/11] plugin: volume snapshot info: also return virtual size Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 03/11] plugin: document volume_resize() method Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 04/11] plugin/storage: volume resize: add snapname parameter Fiona Ebner
2026-03-11  9:44 ` Fiona Ebner [this message]
2026-03-11  9:44 ` [PATCH storage v2 06/11] bump API age and version Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 07/11] partially fix #7094: lvm: snapshot delete: ensure commit target is large enough Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 09/11] plugin: volume snapshot info: correctly return internal snapshot information Fiona Ebner
2026-03-11  9:44 ` [PATCH storage v2 10/11] plugin: volume snapshot info: do not set 'ext' property Fiona Ebner
2026-03-11  9:44 ` [PATCH qemu-server v2 11/11] partially fix #7094: external snapshot delete: ensure commit target is large enough Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311094506.22359-6-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal