From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox_login_manager 1/1] cleanup: replace use of deprecated props and fix dart analyze issues
Date: Fri, 6 Mar 2026 15:35:30 +0100 [thread overview]
Message-ID: <20260306143530.113174-3-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260306143530.113174-1-s.shaji@proxmox.com>
`value` property is deprecated in favor of `initialValue` starting from
v3.35 [0]. Replaced the use of `value` prop with `initialValue`. Additionaly,
removed the library name, as that is not necessary anymore [1].
[0] - https://docs.flutter.dev/release/breaking-changes/deprecate-dropdownbuttonformfield-value
[1] - https://dart.dev/tools/linter-rules/unnecessary_library_name
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
lib/proxmox_login_form.dart | 2 +-
lib/proxmox_login_manager.dart | 2 +-
lib/proxmox_tfa_form.dart | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index b69636d..5b9a64e 100644
--- a/lib/proxmox_login_form.dart
+++ b/lib/proxmox_login_form.dart
@@ -125,7 +125,7 @@ class _ProxmoxLoginFormState extends State<ProxmoxLoginForm> {
onChanged: widget.onDomainChanged,
selectedItemBuilder: (context) =>
widget.accessDomains!.map((e) => Text(e!.realm)).toList(),
- value: widget.selectedDomain,
+ initialValue: widget.selectedDomain,
),
Stack(
children: [
diff --git a/lib/proxmox_login_manager.dart b/lib/proxmox_login_manager.dart
index 8b09583..7868683 100644
--- a/lib/proxmox_login_manager.dart
+++ b/lib/proxmox_login_manager.dart
@@ -1,4 +1,4 @@
-library proxmox_login_manager;
+library;
export 'proxmox_login_selector.dart';
export 'proxmox_login_model.dart';
diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart
index ba18c54..79273fa 100644
--- a/lib/proxmox_tfa_form.dart
+++ b/lib/proxmox_tfa_form.dart
@@ -99,7 +99,7 @@ class _ProxmoxTfaFormState extends State<ProxmoxTfaForm> {
},
selectedItemBuilder: (context) =>
_tfaKinds.map((e) => Text(e)).toList(),
- value: _selectedTfaKind,
+ initialValue: _selectedTfaKind,
),
TextField(
controller: _codeController,
--
2.47.3
prev parent reply other threads:[~2026-03-06 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 14:35 [PATCH proxmox{_dart_api_client,_login_manager} 0/2] cleanup: replace deprecated property " Shan Shaji
2026-03-06 14:35 ` [PATCH proxmox_dart_api_client 1/1] fix: cleanup: dart analysis issues found by dart linter Shan Shaji
2026-03-06 14:35 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306143530.113174-3-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.