[PATCH proxmox v2 4/4] s3-client: return list of errors when deleting by prefix

[Christian Ebner <c.ebner@proxmox.com>]

Previously only a boolean flag indicating whether there was an error
or not was returned. Now return a list of errors which occurred
when performing object deletion. This allows to better log and
inspect error causes.

Further, since this is now part of the public facing api, expose the
DeleteObjectError type to allow for error handling on the call side.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 1:
- not present in previous version

 proxmox-s3-client/src/client.rs | 18 +++++++++---------
 proxmox-s3-client/src/lib.rs    |  2 ++
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index 5eea4dd3..435b3992 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -666,12 +666,12 @@ impl S3Client {
 
     /// Delete objects by given key prefix.
     /// Requires at least 2 api calls.
-    pub async fn delete_objects_by_prefix(&self, prefix: &S3PathPrefix) -> Result<bool, Error> {
+    pub async fn delete_objects_by_prefix(&self, prefix: &S3PathPrefix) -> Result<Vec<DeleteObjectError>, Error> {
         // S3 API does not provide a convenient way to delete objects by key prefix.
         // List all objects with given group prefix and delete all objects found, so this
         // requires at least 2 API calls.
         let mut next_continuation_token: Option<String> = None;
-        let mut delete_errors = false;
+        let mut delete_errors = Vec::new();
         loop {
             let list_objects_result = self
                 .list_objects_v2(prefix, next_continuation_token.as_deref())
@@ -684,8 +684,8 @@ impl S3Client {
                 .collect();
 
             let response = self.delete_objects(&objects_to_delete).await?;
-            if response.error.is_some() {
-                delete_errors = true;
+            if let Some(mut errors) = response.error {
+                delete_errors.append(&mut errors);
             }
 
             if list_objects_result.is_truncated {
@@ -713,12 +713,12 @@ impl S3Client {
         prefix: &S3PathPrefix,
         suffix: &str,
         excldue_from_parent: &[&str],
-    ) -> Result<bool, Error> {
+    ) -> Result<Vec<DeleteObjectError>, Error> {
         // S3 API does not provide a convenient way to delete objects by key prefix.
         // List all objects with given group prefix and delete all objects found, so this
         // requires at least 2 API calls.
         let mut next_continuation_token: Option<String> = None;
-        let mut delete_errors = false;
+        let mut delete_errors = Vec::new();
         let mut prefix_filters = Vec::new();
         let mut list_objects = Vec::new();
         loop {
@@ -772,9 +772,9 @@ impl S3Client {
             .collect();
 
         for objects in objects_to_delete.chunks(1000) {
-            let result = self.delete_objects(objects).await?;
-            if result.error.is_some() {
-                delete_errors = true;
+            let response = self.delete_objects(objects).await?;
+            if let Some(mut errors) = response.error {
+                delete_errors.append(&mut errors);
             }
         }
 
diff --git a/proxmox-s3-client/src/lib.rs b/proxmox-s3-client/src/lib.rs
index d02fd0dc..5c8c4b08 100644
--- a/proxmox-s3-client/src/lib.rs
+++ b/proxmox-s3-client/src/lib.rs
@@ -33,3 +33,5 @@ mod object_key;
 pub use object_key::S3ObjectKey;
 #[cfg(feature = "impl")]
 mod response_reader;
+#[cfg(feature = "impl")]
+pub use response_reader::DeleteObjectError;
-- 
2.47.3