all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* applied: [PATCH qemu-server] guest fsfreeze: fix applying default value for configuration sub-property
@ 2026-03-04 13:42 Fiona Ebner
  0 siblings, 0 replies; only message in thread
From: Fiona Ebner @ 2026-03-04 13:42 UTC (permalink / raw)
  To: pve-devel

The && operator has higher precedence than //, so parentheses are
needed.

Fixes: 7546da2c ("api: import: follow guest-fsfreeze setting")
Fixes: 9d359700 ("fix #1964: honor guest-fsfreeze setting for replications and snapshots")
Fixes: 08ae75f5 ("api: clone_vm: follow guest-fsfreeze setting")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/API2/Qemu.pm  | 4 ++--
 src/PVE/QemuConfig.pm | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 1f0864f5..59ff8181 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -375,7 +375,7 @@ my $import_from_volid = sub {
         my ($src_storeid) = PVE::Storage::parse_volume_id($src_volid);
 
         my $qga = $src_conf->{agent}
-            && PVE::QemuServer::Agent::get_qga_key($src_conf, 'guest-fsfreeze') // 1;
+            && (PVE::QemuServer::Agent::get_qga_key($src_conf, 'guest-fsfreeze') // 1);
 
         return PVE::QemuServer::clone_disk(
             $storecfg,
@@ -4560,7 +4560,7 @@ __PACKAGE__->register_method({
                         if $opt eq 'efidisk0';
 
                     my $qga = $oldconf->{agent}
-                        && PVE::QemuServer::Agent::get_qga_key($oldconf, 'guest-fsfreeze') // 1;
+                        && (PVE::QemuServer::Agent::get_qga_key($oldconf, 'guest-fsfreeze') // 1);
 
                     my $newdrive = PVE::QemuServer::clone_disk(
                         $storecfg,
diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
index 6b90b8bb..462d1d6d 100644
--- a/src/PVE/QemuConfig.pm
+++ b/src/PVE/QemuConfig.pm
@@ -299,7 +299,7 @@ sub __snapshot_check_freeze_needed {
             $running
                 && PVE::QemuServer::Agent::get_qga_key($config, 'enabled')
                 && PVE::QemuServer::Agent::qga_check_running($vmid)
-                && PVE::QemuServer::Agent::get_qga_key($config, 'guest-fsfreeze') // 1,
+                && (PVE::QemuServer::Agent::get_qga_key($config, 'guest-fsfreeze') // 1),
         );
     } else {
         return ($running, 0);
-- 
2.47.3





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-03-04 13:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-04 13:42 applied: [PATCH qemu-server] guest fsfreeze: fix applying default value for configuration sub-property Fiona Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal