all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v3 14/18] ui: qemu: wizard: make iso confid architecture specific
Date: Mon,  2 Mar 2026 14:21:02 +0100	[thread overview]
Message-ID: <20260302132913.3169037-15-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260302132913.3169037-1-d.csapak@proxmox.com>

e.g. on aarch64, there is no ide bus, so we can't use ide2. Instead use
'scsi2' there. We have to slightly adapt the MultiHDEdit panel to
account for a possibly different confid here.

Since windows is currently not available for aarch64, the confid for the
second cd stays the same for now, but has to be adapted if we allow
windows on aarch64 in the future.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/qemu/CreateWizard.js |  3 +++
 www/manager6/qemu/MultiHDEdit.js  |  4 +++-
 www/manager6/qemu/OSPanel.js      | 10 ++++++++++
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index 8f192284..06760230 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -225,6 +225,9 @@ Ext.define('PVE.qemu.CreateWizard', {
         {
             xtype: 'pveQemuOSPanel',
             title: gettext('OS'),
+            bind: {
+                arch: '{current.architecture}',
+            },
         },
         {
             xtype: 'pveQemuSystemPanel',
diff --git a/www/manager6/qemu/MultiHDEdit.js b/www/manager6/qemu/MultiHDEdit.js
index 220167de..e69f3885 100644
--- a/www/manager6/qemu/MultiHDEdit.js
+++ b/www/manager6/qemu/MultiHDEdit.js
@@ -45,11 +45,13 @@ Ext.define('PVE.qemu.MultiHDPanel', {
             let vm = me.getViewModel();
 
             let res = {
-                ide2: 'media=cdrom',
                 scsihw: vm.get('current.scsihw'),
                 ostype: vm.get('current.ostype'),
             };
 
+            let isoConfig = vm.get('current.isoConfig') ?? 'ide2';
+            res[isoConfig] = 'media=cdrom';
+
             if (vm.get('current.ide0') === 'some') {
                 res.ide0 = 'media=cdrom';
             }
diff --git a/www/manager6/qemu/OSPanel.js b/www/manager6/qemu/OSPanel.js
index 136c0316..3d2b5a3e 100644
--- a/www/manager6/qemu/OSPanel.js
+++ b/www/manager6/qemu/OSPanel.js
@@ -10,6 +10,16 @@ Ext.define('PVE.qemu.OSPanel', {
         padding: '0 10',
     },
 
+    setArch: function (arch) {
+        let me = this;
+        let [controller, id] = PVE.qemu.Architecture.defaultCDDrive[arch] ?? ['ide', 2];
+        let vm = me.getController().getViewModel();
+        let conf = `${controller}${id}`;
+        vm.set('current.isoConfig', conf);
+        me.lookup('cdSelector').confid = conf;
+        // TODO change confid for second cd if windows is allowed for other architectures
+    },
+
     controller: {
         xclass: 'Ext.app.ViewController',
         control: {
-- 
2.47.3





  parent reply	other threads:[~2026-03-02 13:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 13:20 [PATCH manager v3 00/18] enable qemu vm architecture selection Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 01/18] api/pvestatd: broadcast and expose non-x86 host architecture Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 02/18] ui: qemu: wizard: refactor ostype and cd selector into an OSPanel Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 03/18] ui: form: add filtered KVComboBox Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 04/18] ui: resource store: add architecture field Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 05/18] ui: qemu: add architecture specific defaults and helpers Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 06/18] ui: qemu: add architecture field in wizard and hardware view Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 07/18] ui: qemu: make scsi hw selector architecture aware Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 08/18] ui: qemu: make osdefaults " Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 09/18] ui: qemu: make os type selector " Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 10/18] ui: qemu: make machine panels/fields " Dominik Csapak
2026-03-02 13:20 ` [PATCH manager v3 11/18] ui: qemu: make bios selector " Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 12/18] ui: qemu: make sortByPreviousUsage " Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 13/18] ui: qemu: wizard: use defaults to populate machine and bios Dominik Csapak
2026-03-02 13:21 ` Dominik Csapak [this message]
2026-03-02 13:21 ` [PATCH manager v3 15/18] ui: qemu: make bus selector architecture aware Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 16/18] ui: qemu: make processor edit " Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 17/18] ui: qemu: change ui default for cpu model Dominik Csapak
2026-03-02 13:21 ` [PATCH manager v3 18/18] ui: qemu: set arch parameter for fetch machine types from api Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302132913.3169037-15-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal