From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v3 02/10] shared-memory: add method without tmpfs check for mmap file location
Date: Tue, 24 Feb 2026 10:13:46 +0100 [thread overview]
Message-ID: <20260224091406.169080-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260224091406.169080-1-c.ebner@proxmox.com>
For some usecases, e.g. s3 client request counters, the mmapped file
should outlive a reboot and must therefore be placed on persistent
storage, not just a tmpfs.
Provide a dedicated method which does not perform the check, keeping
the current interface untouched.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-shared-memory/src/lib.rs | 41 ++++++++++++++++++++++++++++++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/proxmox-shared-memory/src/lib.rs b/proxmox-shared-memory/src/lib.rs
index b067d1b9..da057366 100644
--- a/proxmox-shared-memory/src/lib.rs
+++ b/proxmox-shared-memory/src/lib.rs
@@ -80,7 +80,25 @@ fn mmap_file<T: Init>(file: &mut File, initialize: bool) -> Result<Mmap<T>, Erro
}
impl<T: Sized + Init> SharedMemory<T> {
+ /// Open and mmap the file given at path, checking if the file resides on tmpfs. Further,
+ /// checks the size to be multiples of the page size.
+ /// Creates the file and path directories with given create options if they do not exist.
pub fn open(path: &Path, options: CreateOptions) -> Result<Self, Error> {
+ Self::open_impl(path, options, false)
+ }
+
+ /// Open and mmap the file given at path, without checking if it is located on a tmpfs.
+ /// Checks the size to be multiples of the page size.
+ /// Creates the file and path directories with given create options if they do not exist.
+ pub fn open_non_tmpfs(path: &Path, options: CreateOptions) -> Result<Self, Error> {
+ Self::open_impl(path, options, true)
+ }
+
+ fn open_impl(
+ path: &Path,
+ options: CreateOptions,
+ skip_tmpfs_check: bool,
+ ) -> Result<Self, Error> {
let size = std::mem::size_of::<T>();
let up_size = up_to_page_size(size);
@@ -92,12 +110,31 @@ impl<T: Sized + Init> SharedMemory<T> {
);
}
- let mmap = Self::open_shmem(path, options)?;
+ let mmap = Self::open_shmem_impl(path, options, skip_tmpfs_check)?;
Ok(Self { mmap })
}
+ /// Open and mmap the file given at path, checking if the file resides on tmpfs.
+ /// Creates the file and path directories with given create options if they do not exist.
pub fn open_shmem<P: AsRef<Path>>(path: P, options: CreateOptions) -> Result<Mmap<T>, Error> {
+ Self::open_shmem_impl(path, options, false)
+ }
+
+ /// Open and mmap the file given at path, without checking if it is located on a tmpfs.
+ /// Creates the file and path directories with given create options if they do not exist.
+ pub fn open_shmem_non_tmpfs<P: AsRef<Path>>(
+ path: P,
+ options: CreateOptions,
+ ) -> Result<Mmap<T>, Error> {
+ Self::open_shmem_impl(path, options, true)
+ }
+
+ fn open_shmem_impl<P: AsRef<Path>>(
+ path: P,
+ options: CreateOptions,
+ skip_tmpfs_check: bool,
+ ) -> Result<Mmap<T>, Error> {
let path = path.as_ref();
let dir_name = path
@@ -105,7 +142,7 @@ impl<T: Sized + Init> SharedMemory<T> {
.ok_or_else(|| format_err!("bad path {:?}", path))?
.to_owned();
- if !dir_name.ends_with("shmemtest") {
+ if !(dir_name.ends_with("shmemtest") || skip_tmpfs_check) {
let statfs = nix::sys::statfs::statfs(&dir_name)?;
if statfs.filesystem_type() != nix::sys::statfs::TMPFS_MAGIC {
bail!("path {:?} is not on tmpfs", dir_name);
--
2.47.3
next prev parent reply other threads:[~2026-02-24 9:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 9:13 [PATCH proxmox{,-backup} v3 00/22] partially fix #6563: add s3 request and traffic counter statistics Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 01/10] proxmox-sys: expose msync to flush mmapped contents to filesystem Christian Ebner
2026-02-24 9:13 ` Christian Ebner [this message]
2026-02-24 9:13 ` [PATCH proxmox v3 03/10] shared-memory: expose msync to flush in-memory " Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 04/10] s3-client: add persistent shared request counters for client Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 05/10] s3-client: add counters for upload/download traffic Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 06/10] s3-client: account for upload traffic on successful request sending Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 07/10] s3-client: account for downloaded bytes in incoming response body Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 08/10] s3-client: request counters: periodically persist counters to file Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 09/10] s3-client: sync flush request counters on client instance drop Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 10/10] pbs-api-types: define api type for s3 request statistics Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 01/12] metrics: split common module imports into individual use statements Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 02/12] datastore: collect request statistics for s3 backed datastores Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 03/12] datastore: expose request counters " Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 04/12] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 05/12] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 06/12] datastore: add helper method to get datastore backend type Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 07/12] ui: improve variable name indirectly fixing typo Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 08/12] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 09/12] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 10/12] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 11/12] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 12/12] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224091406.169080-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.