From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token
Date: Wed, 18 Feb 2026 17:41:28 +0100 [thread overview]
Message-ID: <20260218164135.413762-1-s.shaji@proxmox.com> (raw)
If a user removed a remote without deleting its associated token,
PDM would not allow re-adding the same remote unless the token
was changed. To fix this, support for optionally deleting the token
on the remote has been added.
new changes:
- use ConfirmDialog widget for creating the confirmation dialog.
- add token deletion as opt-out feature.
History
=======
changes since v3: Thanks @Lukas and @Maximiliano
- addressed nit comments.
- percent-encode the `userid` parameter.
- rename PbsClient's delete_admin_token function to delete_token.
- by default set the CLIs `delete-token` option to `true`. So by default
the token will be deleted unless the option is set to false.
- remove `type` attribute from the `delete-token` schema.
- fix the alignment of checkbox and text.
changes since v2:
- regenerate the `delete_token` method. The new generate code has
`percent_encoding` wrapped around the params to handle non-alphanumeric
characters.
changes since v3:
- locked the remote config inorder to avoid race condition. Thanks @Michael
- included missing admin cli implementation. Thanks @Michael
- addressed nit comments. Thanks @Shannon
proxmox-datacenter-manager:
Shan Shaji (6):
server: pbs-client: add method to delete token from remote
fix #6914: api: add support to delete token from remote
pdm-client: accept `delete-token` argument for deleting api token
fix #6914: cli-client: add option to delete token from remote
fix #6914: ui: add remove remote dialog with optional token deletion
fix #6914: cli-admin: add option to delete token from remote
cli/admin/src/remotes.rs | 17 ++++--
cli/client/src/remotes.rs | 11 +++-
lib/pdm-client/src/lib.rs | 11 +++-
server/src/api/remotes.rs | 46 +++++++++++++-
server/src/pbs_client.rs | 16 ++++-
ui/src/remotes/config.rs | 38 ++++++++----
ui/src/remotes/mod.rs | 2 +
ui/src/remotes/remove_remote.rs | 103 ++++++++++++++++++++++++++++++++
8 files changed, 222 insertions(+), 22 deletions(-)
create mode 100644 ui/src/remotes/remove_remote.rs
proxmox:
Shan Shaji (1):
pve-api-types: generate missing `delete_token` method
pve-api-types/generate.pl | 1 +
pve-api-types/src/generated/code.rs | 15 +++++++++++++++
2 files changed, 16 insertions(+)
Summary over all repositories:
10 files changed, 238 insertions(+), 22 deletions(-)
--
Generated by git-murpp 0.8.1
next reply other threads:[~2026-02-18 16:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 16:41 Shan Shaji [this message]
2026-02-18 16:41 ` [PATCH datacenter-manager v4 1/6] server: pbs-client: add method to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 2/6] fix #6914: api: add support " Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 4/6] fix #6914: cli-client: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 5/6] fix #6914: ui: add remove remote dialog with optional token deletion Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 6/6] fix #6914: cli-admin: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH proxmox v4 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218164135.413762-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.