all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server] verify device removal: mention that device might still be busy in guest on failure
Date: Fri, 13 Feb 2026 16:38:17 +0100	[thread overview]
Message-ID: <20260213153836.142466-1-f.ebner@proxmox.com> (raw)

A very likely reason for a device removal to time out is if the device
is still busy in the guest. In particular, as reported in [0], Windows
does not release a VirtIO block device when there is ongoing IO.

Increasing the timeout was considered, but during testing, either the
device was removed very quickly or not at all, so waiting longer can
be pointless and annoying.

[0]: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/1483#issuecomment-3897226530

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 5d2dbe03..c2564f1f 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -4129,7 +4129,7 @@ sub qemu_devicedelverify {
         sleep 1;
     }
 
-    die "error on hot-unplugging device '$deviceid'\n";
+    die "error on hot-unplugging device '$deviceid' - still busy in guest?\n";
 }
 
 sub qemu_findorcreatescsihw {
-- 
2.47.3





                 reply	other threads:[~2026-02-13 15:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260213153836.142466-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal