From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 3/3] ui: expose flag to use node's http proxy in remote edit window
Date: Wed, 11 Feb 2026 17:18:45 +0100 [thread overview]
Message-ID: <20260211161845.1006528-5-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260211161845.1006528-1-c.ebner@proxmox.com>
Allows to set/clear the flag to enable using the node http proxy
config for given remote config. Place in the advanced settings to not
intrude in current remote edit window layout to much.
Defaults to not being set, clear from config if unset to avoid config
bloating.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
www/window/RemoteEdit.js | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js
index 9e8353ff8..e9ce709f0 100644
--- a/www/window/RemoteEdit.js
+++ b/www/window/RemoteEdit.js
@@ -128,6 +128,21 @@ Ext.define('PBS.window.RemoteEdit', {
fieldLabel: gettext('Comment'),
},
],
+ advancedColumn1: [
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext("Use node proxy"),
+ name: 'use-node-proxy',
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext(
+ "Use the node's http proxy configuration for remote connections.",
+ ),
+ },
+ uncheckedValue: false,
+ value: false,
+ },
+ ],
},
setValues: function (values) {
@@ -153,6 +168,10 @@ Ext.define('PBS.window.RemoteEdit', {
delete values.password;
}
+ if (!me.isCreate) {
+ PBS.Utils.delete_if_default(values, 'use-node-proxy', false);
+ }
+
return values;
},
});
--
2.47.3
prev parent reply other threads:[~2026-02-11 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 16:18 [PATCH proxmox{,-backup} 0/4] fix #3723: allow using node http proxy for remote connections Christian Ebner
2026-02-11 16:18 ` [PATCH proxmox 1/1] pbs-api-types: remote: add flag to use node proxy for remote connect Christian Ebner
2026-02-11 16:18 ` [PATCH proxmox-backup 1/3] http client: use http proxy from client options if set Christian Ebner
2026-02-11 16:18 ` [PATCH proxmox-backup 2/3] fix #3723: api: remote: optionally use node proxy config for http client Christian Ebner
2026-02-11 16:18 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211161845.1006528-5-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.