all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH container] networkedit: fix #4911: changed primaryfield to proxmoxtextfield to allow empty bond-primary
Date: Mon,  9 Feb 2026 16:49:16 +0100	[thread overview]
Message-ID: <20260209154916.54446-1-l.sichert@proxmox.com> (raw)

Currently, when creating an active-backup bond, it is not possible to leave the primary-bond field blank, even though this value is optional in the backend.
If no value is currently set in the frontend, it sends the value '' to the backend. There, it is interpreted as the name of an interface, which is incorrect, and therefore the error 'bond-primary: invalid format - invalid network interface name '' ' is displayed.
Changing the field type to 'proxmoxtextfield' will prevent the empty string from being sent due to the way we submit the data and make it therefore possible to not set any value in the frontend.
Addtionally, the deleteEmpty flag is set, so that devices, that were unset, will be deleted by the backend.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
 src/node/NetworkEdit.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index 39c7e35..c945139 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -239,10 +239,11 @@ Ext.define('Proxmox.node.NetworkEdit', {
                 disabled: true,
             });
 
-            let primaryfield = Ext.createWidget('textfield', {
+            let primaryfield = Ext.createWidget('proxmoxtextfield', {
                 fieldLabel: 'bond-primary',
                 name: 'bond-primary',
                 value: '',
+                deleteEmpty: !me.isCreate,
                 disabled: true,
             });
 
-- 
2.47.3




             reply	other threads:[~2026-02-09 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 15:49 Lukas Sichert [this message]
2026-02-09 16:18 ` Friedrich Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260209154916.54446-1-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal