all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC cluster/docs/manager/proxmox{,-perl-rs,-widget-toolkit} 00/15] fix #7238: Add XOAUTH2 authentication support for SMTP notification targets
Date: Wed,  4 Feb 2026 17:13:39 +0100	[thread overview]
Message-ID: <20260204161354.458814-1-a.bied-charreton@proxmox.com> (raw)

Sending this as an RFC to get early feedback on the overall direction.

This series adds OAuth2 support for SMTP notification targets, motivated by Microsoft's
upcoming deprecation of basic authentication for SMTP [1]. Google and Microsoft are supported as
OAuth2 providers.

The main architectural decisions are:

- OAuth2 refresh tokens are treated as state, not config. They are persisted in a separate JSON file and managed
  entirely from the Rust side via standard I/O.

- The oauth2 crate is used with a local ureq backend (newtype over ureq::Agent), since the upstream ureq feature
  is currently patched out in Debian due to a ureq 2/3 version mismatch [2].

- Token refresh is triggered both proactively via pveupdate and when sending a notification to handle idle periods
  and providers like Microsoft that rotate refresh tokens on every use.

Known issues:
- Microsoft is untested (no test tenant, somehow impossible to create a free test account)

[1] https://techcommunity.microsoft.com/blog/exchange/updated-exchange-online-smtp-auth-basic-authentication-deprecation-timeline/4489835
[2] https://git.proxmox.com/?p=debcargo-conf.git;a=blob;f=src/oauth2/debian/patches/disable-ureq.patch;h=828b883a83a86927c5cd32df055226a5e78e8bea;hb=refs/heads/proxmox/trixie


proxmox:

Arthur Bied-Charreton (5):
  notify: Introduce xoauth2 module
  notify: Add state file handling
  notify: Update Endpoint trait and Bus to use State
  notify: smtp: add OAuth2/XOAUTH2 authentication support
  notify: Add test for State

 proxmox-notify/Cargo.toml                |   5 +
 proxmox-notify/debian/control            |  12 +-
 proxmox-notify/src/api/common.rs         |  70 ++++++-
 proxmox-notify/src/api/smtp.rs           | 144 +++++++++++---
 proxmox-notify/src/context/mod.rs        |   2 +
 proxmox-notify/src/context/pbs.rs        |   4 +
 proxmox-notify/src/context/pve.rs        |   4 +
 proxmox-notify/src/context/test.rs       |   4 +
 proxmox-notify/src/endpoints/gotify.rs   |   4 +-
 proxmox-notify/src/endpoints/sendmail.rs |   4 +-
 proxmox-notify/src/endpoints/smtp.rs     | 227 +++++++++++++++++++++--
 proxmox-notify/src/endpoints/webhook.rs  |   4 +-
 proxmox-notify/src/lib.rs                | 157 ++++++++++++++--
 proxmox-notify/src/xoauth2.rs            | 146 +++++++++++++++
 14 files changed, 718 insertions(+), 69 deletions(-)
 create mode 100644 proxmox-notify/src/xoauth2.rs


proxmox-perl-rs:

Arthur Bied-Charreton (1):
  notify: update bindings with new OAuth2 parameters

 common/src/bindings/notify.rs | 44 +++++++++++++++++++++++++++++++----
 1 file changed, 40 insertions(+), 4 deletions(-)


proxmox-widget-toolkit:

Arthur Bied-Charreton (2):
  utils: Add OAuth2 flow handlers
  notifications: Add opt-in OAuth2 support for SMTP targets

 src/Utils.js                   |  84 +++++++++++++++
 src/panel/SmtpEditPanel.js     | 191 +++++++++++++++++++++++++++++++--
 src/window/EndpointEditBase.js |   1 +
 3 files changed, 265 insertions(+), 11 deletions(-)


pve-manager:

Arthur Bied-Charreton (5):
  notifications: Add OAuth2 parameters to schema and add/update
    endpoints
  notifications: Add refresh-targets endpoint
  notifications: Trigger notification target refresh in pveupdate
  notifications: Handle OAuth2 callback in login handler
  notifications: Opt into OAuth2 authentication

 PVE/API2/Cluster/Notifications.pm | 89 +++++++++++++++++++++++++++++++
 bin/pveupdate                     |  9 ++++
 www/manager6/Utils.js             | 10 ++++
 www/manager6/Workspace.js         | 20 +++++++
 4 files changed, 128 insertions(+)


pve-cluster:

Arthur Bied-Charreton (1):
  notifications: Add refresh_targets subroutine to PVE::Notify

 src/PVE/Notify.pm | 6 ++++++
 1 file changed, 6 insertions(+)


pve-docs:

Arthur Bied-Charreton (1):
  notifications: Add section about OAuth2 to SMTP targets docs

 notifications.adoc | 44 ++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 40 insertions(+), 4 deletions(-)


Summary over all repositories:
  24 files changed, 1197 insertions(+), 88 deletions(-)

-- 
Generated by murpp 0.9.0



             reply	other threads:[~2026-02-04 16:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 16:13 Arthur Bied-Charreton [this message]
2026-02-04 16:13 ` [PATCH proxmox 1/5] notify: Introduce xoauth2 module Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 2/5] notify: Add state file handling Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 3/5] notify: Update Endpoint trait and Bus to use State Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 4/5] notify: smtp: add OAuth2/XOAUTH2 authentication support Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox 5/5] notify: Add test for State Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox-perl-rs 1/1] notify: update bindings with new OAuth2 parameters Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox-widget-toolkit 1/2] utils: Add OAuth2 flow handlers Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH proxmox-widget-toolkit 2/2] notifications: Add opt-in OAuth2 support for SMTP targets Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 1/5] notifications: Add OAuth2 parameters to schema and add/update endpoints Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 2/5] notifications: Add refresh-targets endpoint Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 3/5] notifications: Trigger notification target refresh in pveupdate Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 4/5] notifications: Handle OAuth2 callback in login handler Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-manager 5/5] notifications: Opt into OAuth2 authentication Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-cluster 1/1] notifications: Add refresh_targets subroutine to PVE::Notify Arthur Bied-Charreton
2026-02-04 16:13 ` [PATCH pve-docs 1/1] notifications: Add section about OAuth2 to SMTP targets docs Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204161354.458814-1-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal