all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] 8to9: adapt to changed signature of get_vm_machine()
Date: Thu, 29 Jan 2026 14:26:11 +0100	[thread overview]
Message-ID: <20260129132623.127384-1-f.ebner@proxmox.com> (raw)

The signature change in qemu-server does not lead to any breakage,
because the function still looks at $conf->{arch}. Still, it should be
adapted.

Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Dependency bump for qemu-server needed!

 PVE/CLI/pve8to9.pm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 0c4b2343..662ee943 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -931,7 +931,7 @@ my sub check_qemu_machine_versions {
         my $conf = PVE::QemuConfig->load_config($vmid);
 
         # first, actually configured machine version
-        my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $conf->{arch});
+        my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf);
         if (
             PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
             && !PVE::QemuServer::Machine::is_machine_version_at_least($machine_type, @baseline)
@@ -942,9 +942,7 @@ my sub check_qemu_machine_versions {
         # second, if hibernated, running machine version
         if ($conf->{vmstate}) {
             my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
-                $conf,
-                $conf->{runningmachine},
-                $conf->{arch},
+                $conf, $conf->{runningmachine},
             );
             if (
                 PVE::QemuServer::Machine::extract_version($machine_type) # no version means latest
@@ -964,7 +962,6 @@ my sub check_qemu_machine_versions {
                 my $machine_type = PVE::QemuServer::Machine::get_vm_machine(
                     $snap_conf,
                     $snap_conf->{runningmachine},
-                    $snap_conf->{arch},
                 );
                 if ( # no version means latest
                     PVE::QemuServer::Machine::extract_version($machine_type)
-- 
2.47.3





                 reply	other threads:[~2026-01-29 13:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129132623.127384-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal