all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container v3 5/8] api: create: create_ct_determine_mp_param: improve code style
Date: Fri, 23 Jan 2026 15:34:25 +0100	[thread overview]
Message-ID: <20260123143454.150800-6-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260123143454.150800-1-f.ebner@proxmox.com>

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v3.

 src/PVE/API2/LXC.pm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 8623d63..f7d5de4 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -177,7 +177,8 @@ my sub create_ct_determine_mp_param {
             if ($type eq 'volume') {
                 die "unable to detect disk size - please specify $ms (size)\n"
                     if !defined($mountpoint->{size});
-                my $disksize = $mountpoint->{size} / (1024 * 1024 * 1024); # create_disks expects GB as unit size
+                # create_disks expects GB as unit size
+                my $disksize = $mountpoint->{size} / (1024 * 1024 * 1024);
                 delete $mountpoint->{size};
                 $mountpoint->{volume} = "$storage:$disksize";
                 $mp_param->{$ms} = PVE::LXC::Config->print_ct_mountpoint(
@@ -185,9 +186,10 @@ my sub create_ct_determine_mp_param {
                 );
             } else {
                 my $type = $mountpoint->{type};
-                die
-                    "restoring rootfs to $type mount is only possible by specifying -rootfs manually!\n"
-                    if ($ms eq 'rootfs');
+                if ($ms eq 'rootfs') {
+                    die "restoring rootfs to $type mount is only possible by specifying -rootfs"
+                        . " manually!\n";
+                }
                 die "restoring '$ms' to $type mount is only possible for root\n"
                     if !$is_root;
 
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2026-01-23 14:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 14:34 [pve-devel] [PATCH-SERIES container/manager v3 0/8] api: restore: allow keeping not backed-up volumes Fiona Ebner
2026-01-23 14:34 ` [pve-devel] [PATCH container v3 1/8] api: create: move delayed_mp_param variable closer to usage Fiona Ebner
2026-01-23 14:34 ` [pve-devel] [PATCH container v3 2/8] api: create: reduce scope for $mp_param variable Fiona Ebner
2026-01-23 14:34 ` [pve-devel] [PATCH container v3 3/8] api: create: factor out create_ct_determine_mp_param helper Fiona Ebner
2026-01-23 14:34 ` [pve-devel] [PATCH container v3 4/8] run make tidy Fiona Ebner
2026-01-23 14:34 ` Fiona Ebner [this message]
2026-01-23 14:34 ` [pve-devel] [PATCH container v3 6/8] api: create: get rid of $storage_only_mode variable Fiona Ebner
2026-01-23 14:34 ` [pve-devel] [PATCH container v3 7/8] api: restore: allow keeping not backed-up volumes Fiona Ebner
2026-01-23 14:34 ` [pve-devel] [PATCH manager v3 8/8] ui: restore: enable safeguarding of mount point volumes by default Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260123143454.150800-6-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal