* [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new'
@ 2026-01-20 11:33 Hannes Laimer
2026-01-20 13:24 ` Nicolas Frey
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-01-20 11:33 UTC (permalink / raw)
To: pbs-devel
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/api2/backup/environment.rs | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs
index bd9c5211..3c624b18 100644
--- a/src/api2/backup/environment.rs
+++ b/src/api2/backup/environment.rs
@@ -799,10 +799,13 @@ impl BackupEnvironment {
false,
move |worker| {
worker.log_message("Automatically verifying newly added snapshot");
-
- // FIXME: update once per-datastore read/verify settings
- // are available to not use default amount of threads here
- let verify_worker = VerifyWorker::new(worker.clone(), datastore, None, None)?;
+ let thread_settings = datastore.thread_settings().clone();
+ let verify_worker = VerifyWorker::new(
+ worker.clone(),
+ datastore,
+ thread_settings.verify_job_read_threads,
+ thread_settings.verify_job_verify_threads,
+ )?;
if !verify_worker.verify_backup_dir_with_lock(
&backup_dir,
worker.upid().clone(),
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new'
2026-01-20 11:33 [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new' Hannes Laimer
@ 2026-01-20 13:24 ` Nicolas Frey
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Frey @ 2026-01-20 13:24 UTC (permalink / raw)
To: pbs-devel
missed this when I added datastore-level thread settings, thanks!
Reviewed-by: Nicolas Frey <n.frey@proxmox.com>
On 1/20/26 12:33 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/api2/backup/environment.rs | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs
> index bd9c5211..3c624b18 100644
> --- a/src/api2/backup/environment.rs
> +++ b/src/api2/backup/environment.rs
> @@ -799,10 +799,13 @@ impl BackupEnvironment {
> false,
> move |worker| {
> worker.log_message("Automatically verifying newly added snapshot");
> -
> - // FIXME: update once per-datastore read/verify settings
> - // are available to not use default amount of threads here
> - let verify_worker = VerifyWorker::new(worker.clone(), datastore, None, None)?;
> + let thread_settings = datastore.thread_settings().clone();
> + let verify_worker = VerifyWorker::new(
> + worker.clone(),
> + datastore,
> + thread_settings.verify_job_read_threads,
> + thread_settings.verify_job_verify_threads,
> + )?;
> if !verify_worker.verify_backup_dir_with_lock(
> &backup_dir,
> worker.upid().clone(),
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-20 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-20 11:33 [pbs-devel] [PATCH proxmox-backup] api: backup: use configured verify thread counts for 'verify-new' Hannes Laimer
2026-01-20 13:24 ` Nicolas Frey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.