From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH ha-manager v2 2/4] manager: group migration: write only non-default failback values
Date: Tue, 20 Jan 2026 09:47:54 +0100 [thread overview]
Message-ID: <20260120084839.103702-3-d.kral@proxmox.com> (raw)
In-Reply-To: <20260120084839.103702-1-d.kral@proxmox.com>
The failback flag for HA resources is set by default, so it is wasteful
to write the default value in the resources config.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/HA/Manager.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 80b29966..c9d1dde5 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -583,7 +583,8 @@ my $migrate_group_persistently = sub {
# prevent unnecessary updates for HA resources that do not change
next if !defined($resources->{$sid}->{group});
- my $param = { failback => $resources->{$sid}->{failback} };
+ my $param = {};
+ $param->{failback} = 0 if !$resources->{$sid}->{failback};
$haenv->update_service_config($sid, $param, 'group');
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-20 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 8:47 [pve-devel] [PATCH-SERIES ha-manager v2 0/4] fix #7133 and improve HA group migration Daniel Kral
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 1/4] fix #7133: manager: group migration: skip update for resources without group Daniel Kral
2026-01-20 8:47 ` Daniel Kral [this message]
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 3/4] config, env: allow bulk updates with update_service_config Daniel Kral
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 4/4] manager: group migration: bulk update changes to resource config Daniel Kral
2026-01-20 10:35 ` [pve-devel] applied: [PATCH-SERIES ha-manager v2 0/4] fix #7133 and improve HA group migration Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120084839.103702-3-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.