From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES ha-manager v2 0/4] fix #7133 and improve HA group migration
Date: Tue, 20 Jan 2026 09:47:52 +0100 [thread overview]
Message-ID: <20260120084839.103702-1-d.kral@proxmox.com> (raw)
Changes from v1 to v2 (Thanks @Fiona!):
- pull $delete parameter into $changes hash in
update_{service,resources}_config
- sort the HA resources' sids when iterating over the $changes hash
Tested the changes for v2 again with:
- creating a groups.cfg and checking whether the groups have been
correctly migrated,
- changing a HA resource to stopped state changes the config too, &
- changing a HA resource's config through the API reflects the
changes in the resources.cfg.
This small patch series improves the HA groups to rules migration for HA
setups with a lot of HA resources:
- Patch 1 reduces the amount of unnecessary updates and is enough for
fixing #7133,
- Patch 2 removes redundant failback flag writes to reduce the resource
config file size, and patch, and
- Patch 3-4 make the resource config in a single write instead of
individual writes.
Tested this for a PVE 8.4 to PVE 9.1 3-node cluster upgrade.
Daniel Kral (4):
fix #7133: manager: group migration: skip update for resources without
group
manager: group migration: write only non-default failback values
config, env: allow bulk updates with update_service_config
manager: group migration: bulk update changes to resource config
src/PVE/API2/HA/Resources.pm | 8 ++++-
src/PVE/HA/Config.pm | 57 +++++++++++++++++++++---------------
src/PVE/HA/Env.pm | 4 +--
src/PVE/HA/Env/PVE2.pm | 4 +--
src/PVE/HA/Manager.pm | 15 ++++++++--
src/PVE/HA/Sim/Env.pm | 4 +--
src/PVE/HA/Sim/Hardware.pm | 19 +++++++++---
7 files changed, 74 insertions(+), 37 deletions(-)
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2026-01-20 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 8:47 Daniel Kral [this message]
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 1/4] fix #7133: manager: group migration: skip update for resources without group Daniel Kral
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 2/4] manager: group migration: write only non-default failback values Daniel Kral
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 3/4] config, env: allow bulk updates with update_service_config Daniel Kral
2026-01-20 8:47 ` [pve-devel] [PATCH ha-manager v2 4/4] manager: group migration: bulk update changes to resource config Daniel Kral
2026-01-20 10:35 ` [pve-devel] applied: [PATCH-SERIES ha-manager v2 0/4] fix #7133 and improve HA group migration Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120084839.103702-1-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.