[pbs-devel] [PATCH proxmox-backup 2/4] tree-wide: fix clippy warnings needless borrow

[Christian Ebner <c.ebner@proxmox.com>]

Omit all needless borrows currently reported by clippy run.

No functional changes.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-datastore/src/chunk_store.rs | 2 +-
 pbs-datastore/src/datastore.rs   | 4 ++--
 src/api2/admin/datastore.rs      | 4 ++--
 src/auth.rs                      | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
index cccfcfcdf..315e18218 100644
--- a/pbs-datastore/src/chunk_store.rs
+++ b/pbs-datastore/src/chunk_store.rs
@@ -758,7 +758,7 @@ impl ChunkStore {
             let gid = pbs_config::backup_group()?.gid;
             create_options = create_options.owner(uid).group(gid);
         }
-        proxmox_sys::fs::replace_file(&path, &[], create_options, false)
+        proxmox_sys::fs::replace_file(path, &[], create_options, false)
     }
 
     /// Mark chunk as expected to be present by writing a file the chunk store.
diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 2f401f6fd..83d209414 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -2007,7 +2007,7 @@ impl DataStore {
     ) -> Result<(bool, u64), Error> {
         match backend {
             DatastoreBackend::Filesystem => self.inner.chunk_store.insert_chunk(chunk, digest),
-            DatastoreBackend::S3(s3_client) => self.insert_chunk_cached(chunk, digest, &s3_client),
+            DatastoreBackend::S3(s3_client) => self.insert_chunk_cached(chunk, digest, s3_client),
         }
     }
 
@@ -2062,7 +2062,7 @@ impl DataStore {
         // or the chunk marker file exists on filesystem. The latter means the chunk has
         // been uploaded in the past, but was evicted from the LRU cache since but was not
         // cleaned up by garbage collection, so contained in the S3 object store.
-        if self.cache_contains(&digest) {
+        if self.cache_contains(digest) {
             tracing::info!("Skip upload of cached chunk {}", hex::encode(digest));
             return Ok((true, chunk_size));
         }
diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs
index ddd894c12..88ad5d53b 100644
--- a/src/api2/admin/datastore.rs
+++ b/src/api2/admin/datastore.rs
@@ -2734,8 +2734,8 @@ pub fn s3_refresh(store: String, rpcenv: &mut dyn RpcEnvironment) -> Result<Valu
 /// Performs an s3 refresh for given datastore. Expects the store to already be in maintenance mode
 /// s3-refresh.
 pub(crate) fn do_s3_refresh(store: &str, worker: &dyn WorkerTaskContext) -> Result<(), Error> {
-    let datastore = DataStore::lookup_datastore(&store, Some(Operation::Lookup))?;
-    run_maintenance_locked(&store, MaintenanceType::S3Refresh, worker, || {
+    let datastore = DataStore::lookup_datastore(store, Some(Operation::Lookup))?;
+    run_maintenance_locked(store, MaintenanceType::S3Refresh, worker, || {
         proxmox_async::runtime::block_on(datastore.s3_refresh())
     })
 }
diff --git a/src/auth.rs b/src/auth.rs
index a930d8cd9..24bb3f753 100644
--- a/src/auth.rs
+++ b/src/auth.rs
@@ -475,7 +475,7 @@ impl proxmox_auth_api::api::AuthContext for PbsAuthContext {
                             path_vec.push(part);
                         }
                     }
-                    user_info.check_privs(&auth_id, &path_vec, *privilege, false)?;
+                    user_info.check_privs(auth_id, &path_vec, *privilege, false)?;
                     return Ok(Some(true));
                 }
             }
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel