* [pbs-devel] [PATCH proxmox-backup v2 1/1] fix: s3: make s3_refresh apihandler sync
@ 2026-01-07 12:46 Nicolas Frey
0 siblings, 0 replies; only message in thread
From: Nicolas Frey @ 2026-01-07 12:46 UTC (permalink / raw)
To: pbs-devel
fixes regression from 524cf1e7 that made `datastore::s3_refresh` sync
but did not change the ApiHandler matching part here
This would result in a panic every time an s3-refresh was initiated
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
Fixes: 524cf1e7 ("api: admin: make s3 refresh handler sync")
Fixes: https://forum.proxmox.com/threads/178655
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
added Fixes trailer to reference blamed commit
src/bin/proxmox_backup_manager/datastore.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
index 57b4ca29..5c65c5ec 100644
--- a/src/bin/proxmox_backup_manager/datastore.rs
+++ b/src/bin/proxmox_backup_manager/datastore.rs
@@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
let result = match info.handler {
- ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
+ ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
_ => unreachable!(),
};
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-01-07 12:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-07 12:46 [pbs-devel] [PATCH proxmox-backup v2 1/1] fix: s3: make s3_refresh apihandler sync Nicolas Frey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.