all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox-fuse-rs] Remove deprecated shared_flag() call from build script
@ 2026-01-05 14:05 Kefu Chai
  0 siblings, 0 replies; only message in thread
From: Kefu Chai @ 2026-01-05 14:05 UTC (permalink / raw)
  To: pve-devel; +Cc: Wolfgang Bumiller

Root cause:
The cc crate deprecated the shared_flag() method because it only
creates static libraries (.a files), making the shared_flag parameter
meaningless and confusing.

The warning indicated:
  warning: use of deprecated method `cc::Build::shared_flag`:
  cc only creates static libraries, setting this does nothing

Impact:
- shared_flag(false) was a no-op that did nothing
- Its removal does not change the build behavior
- The build still produces libglue.a as expected

Fix:
Remove the .shared_flag(false) call from the cc::Build chain.
The build defaults to static library output, which is what we want.

Verification:
- Build completes without warnings
- Generated library is still static (.a)
- No functional changes to the FUSE bindings

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 build.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/build.rs b/build.rs
index d75166e..f9dd5f1 100644
--- a/build.rs
+++ b/build.rs
@@ -11,10 +11,7 @@ fn main() {
 
     let mut cc = cc::Build::new();
 
-    cc.pic(true)
-        .shared_flag(false)
-        .opt_level(3)
-        .flag("-DFUSE_USE_VERSION=35");
+    cc.pic(true).opt_level(3).flag("-DFUSE_USE_VERSION=35");
 
     for flag in ccflags.split_ascii_whitespace() {
         cc.flag(flag);
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-01-05 14:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-05 14:05 [pve-devel] [PATCH proxmox-fuse-rs] Remove deprecated shared_flag() call from build script Kefu Chai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal