From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] [PATCH proxmox-fuse-rs] Remove deprecated shared_flag() call from build script
Date: Mon, 5 Jan 2026 22:05:52 +0800 [thread overview]
Message-ID: <20260105140709.1214107-1-k.chai@proxmox.com> (raw)
Root cause:
The cc crate deprecated the shared_flag() method because it only
creates static libraries (.a files), making the shared_flag parameter
meaningless and confusing.
The warning indicated:
warning: use of deprecated method `cc::Build::shared_flag`:
cc only creates static libraries, setting this does nothing
Impact:
- shared_flag(false) was a no-op that did nothing
- Its removal does not change the build behavior
- The build still produces libglue.a as expected
Fix:
Remove the .shared_flag(false) call from the cc::Build chain.
The build defaults to static library output, which is what we want.
Verification:
- Build completes without warnings
- Generated library is still static (.a)
- No functional changes to the FUSE bindings
Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
build.rs | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/build.rs b/build.rs
index d75166e..f9dd5f1 100644
--- a/build.rs
+++ b/build.rs
@@ -11,10 +11,7 @@ fn main() {
let mut cc = cc::Build::new();
- cc.pic(true)
- .shared_flag(false)
- .opt_level(3)
- .flag("-DFUSE_USE_VERSION=35");
+ cc.pic(true).opt_level(3).flag("-DFUSE_USE_VERSION=35");
for flag in ccflags.split_ascii_whitespace() {
cc.flag(flag);
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2026-01-05 14:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105140709.1214107-1-k.chai@proxmox.com \
--to=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.