[pve-devel] [PATCH docs/guest-common/qemu-server v5 00/11] fix #1964: add setting to always disable freezing a guest's fs

* [pve-devel] [PATCH docs/guest-common/qemu-server v5 00/11] fix #1964: add setting to always disable freezing a guest's fs
@ 2026-01-05 12:16 Maximiliano Sandoval
  2026-01-05 12:16 ` [pve-devel] [PATCH qemu-server v5 1/9] add a guest-fsfreeze qga setting Maximiliano Sandoval
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: Maximiliano Sandoval @ 2026-01-05 12:16 UTC (permalink / raw)
  To: pve-devel

..and add more logging when issuing fsfreeze guest commands.

The new setting takes precedence over freeze-fs-on-backup and deprecates the
former.

- At the moment taking a snapshot without RAM does not log whether there was a
  freeze/thaw, we add logs when issuing freezes/thaws.

- The patch does not result in an extra log line when making a Backup in
  snapshot mode.

- When it is easy to do so, we log if the fsfreeze command was not issued due to
  mismatch between the agent running and the config, e.g. when say that we
  skipped it if the agent is enabled bu the configuration says we shouldn't.

What was tested:

 - Backups of a VM with and another without guest-fsfreeze enabled. They both
   print a message indicating that a fsfreeze happend.

 - A live clone of a VM with and another without guest-fsfreeze enabled. They
   both print a message indicating that a fsfreeze happend.

 - Snapshot of a VM with and another without guest-fsfreeze enabled. Only the
   format logged a message indicating that a fsfreeze happened.

 - Importing a disk of a runing VM with and without guest-fsfreeze enabled. When
   a freeeze is issued a message will be printed, but nothing will be printed if
   it is not issued.

Differences from v4:

 - Take the guest-fsfreeze setting into account when adding disks with
   import-from
 - Mention that importing disks will issue a freeze on the documentation

Differences from v3:

 - Instead of removing logfunc statements and adding a print to the base
   __snapshot_freeze we add a print on the snapshot method which was the one
   missing a log. This means we do not need changes in pve-container anymore.
 - Add a helper to thaw a qemu guest. This is done only for readability.
 - Read the guest config right at the start of the worker
 - Rebase on top of master

Differences from v2:

 - Print a message on live clones when fsfreeze is skipped due to config
 - Clean up code a bit
 - rebase
 - Fix a typo

Differences from v1:

 - Add setting to enable/disable fsfreeze commands
 - Change wording in one log message

qemu-server:

Maximiliano Sandoval (9):
  add a guest-fsfreeze qga setting
  api: clone_vm: follow guest-fsfreeze setting
  fix #1964: follow guest-fsfreeze setting on check freeze needed
  agent: add a guest_fsthaw helper
  port users of guest-fsfreeze-thaw users to helper
  block job: log when a fsfreeze could not happen
  block job: mirror: reword fsfreeze log entry
  deprecate freeze-fs-on-backup qga setting
  api: import: follow guest-fsfreeze setting

 src/PVE/API2/Qemu.pm           | 10 ++++++++--
 src/PVE/QemuConfig.pm          |  5 +++--
 src/PVE/QemuServer/Agent.pm    | 32 +++++++++++++++++++++++++++++++-
 src/PVE/QemuServer/BlockJob.pm | 18 ++++++++++++------
 src/PVE/VZDump/QemuServer.pm   |  9 ++++++---
 5 files changed, 60 insertions(+), 14 deletions(-)

pve-guest-common:

Maximiliano Sandoval (1):
  abstract config: print when {,un}freezing a fs

 src/PVE/AbstractConfig.pm | 2 ++
 1 file changed, 2 insertions(+)

pve-docs:

Maximiliano Sandoval (1):
  qm: document that import-from can issue a fsfreeze

 qm.adoc | 1 +
 1 file changed, 1 insertion(+)

Summary over all repositories:
  7 files changed, 63 insertions(+), 14 deletions(-)

-- 
Generated by murpp 0.9.0

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread