all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH guest-common v4 1/1] abstract config: print when {, un}freezing a fs
Date: Fri,  2 Jan 2026 15:35:44 +0100	[thread overview]
Message-ID: <20260102143544.354066-10-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260102143544.354066-1-m.sandoval@proxmox.com>

There are two callers of __snapshot_freeze: replication and snapshot. On
the former we already use the log function to log both freeze & thaw
instance and in this commit we add the later.

However, note that we do not have access to a log function at this stage
and we simply print.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/AbstractConfig.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
index 420a10d..13accf8 100644
--- a/src/PVE/AbstractConfig.pm
+++ b/src/PVE/AbstractConfig.pm
@@ -840,6 +840,7 @@ sub snapshot_create {
         $class->__snapshot_activate_storages($conf, 0);
 
         if ($freezefs) {
+            print("freeze guest filesystem\n");
             $class->__snapshot_freeze($vmid, 0);
         }
 
@@ -860,6 +861,7 @@ sub snapshot_create {
     if ($running) {
         $class->__snapshot_create_vol_snapshots_hook($vmid, $snap, $running, "after");
         if ($freezefs) {
+            print("unfreeze filesystem\n");
             $class->__snapshot_freeze($vmid, 1);
         }
         $class->__snapshot_create_vol_snapshots_hook($vmid, $snap, $running, "after-unfreeze");
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2026-01-02 14:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-02 14:35 [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 1/8] add a guest-fsfreeze qga setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 2/8] api: clone_vm: follow guest-fsfreeze setting Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 3/8] fix #1964: follow guest-fsfreeze setting on check freeze needed Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 4/8] agent: add a guest_fsthaw helper Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 5/8] port users of guest-fsfreeze-thaw users to helper Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 6/8] block job: log when a fsfreeze could not happen Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 7/8] block job: mirror: reword fsfreeze log entry Maximiliano Sandoval
2026-01-02 14:35 ` [pve-devel] [PATCH qemu-server v4 8/8] deprecate freeze-fs-on-backup qga setting Maximiliano Sandoval
2026-01-02 14:35 ` Maximiliano Sandoval [this message]
2026-01-02 15:27 ` [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs Maximiliano Sandoval
2026-01-02 15:36   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102143544.354066-10-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal