From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server master+stable-bookworm] migration: vm start: avoid config write when there are left-over VM-state-related properties
Date: Fri, 2 Jan 2026 14:17:32 +0100 [thread overview]
Message-ID: <20260102131852.107940-1-f.ebner@proxmox.com> (raw)
The remove_left_over_vmstate_opts() function might write the
configuration, so it cannot be called in the context of a migration,
where the configuration file will be moved over from the source node
later. As reported in the enterprise support, this could cause an
error like:
> close (rename) atomic file '/etc/pve/nodes/XYZ/qemu-server/211.conf' failed: File exists
Fixes: 0db14e60 ("vm start: remove left-over VM-state-related properties")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 69991843..53001b9b 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -5956,7 +5956,7 @@ sub vm_start_nolock {
}
delete $conf->@{qw(lock vmstate running-nets-host-mtu runningmachine runningcpu)};
PVE::QemuConfig->write_config($vmid, $conf);
- } elsif (!$conf->{vmstate}) {
+ } elsif (!$conf->{vmstate} && !$migratedfrom) {
remove_left_over_vmstate_opts($vmid, $conf);
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2026-01-02 13:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102131852.107940-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.