From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] setup: centos: separate dns-search list with semicolons
Date: Tue, 30 Dec 2025 13:55:10 +0100 [thread overview]
Message-ID: <20251230125535.130173-1-m.sandoval@proxmox.com> (raw)
This is a followup of 6e08c550.
Unlike the previous commit, the key `dns-search` is not documented as
part of the manual page `nm-settings-keyfile(5)`. Here we rely solely on
lists being generally semicolon-separated in NetworkManager and the test
case `Test_Wireless_Connection` [1, 2, 3].
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c?ref_type=820e56c5df80d6f5a4019c82f0f60b3303ecfa17#L281
[2] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c?ref_type=820e56c5df80d6f5a4019c82f0f60b3303ecfa17#L370-L372
[3] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/keyfiles/Test_Wired_Connection#L52
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/PVE/LXC/Setup/CentOS.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
index 7bccca2..2469046 100644
--- a/src/PVE/LXC/Setup/CentOS.pm
+++ b/src/PVE/LXC/Setup/CentOS.pm
@@ -245,7 +245,7 @@ sub setup_network_with_networkmanager {
}
if (@name_servers_v4) {
$data .= "dns=" . join(';', @name_servers_v4) . "\n";
- $data .= "dns-search=" . join(' ', PVE::Tools::split_list($searchdomains)) . "\n"
+ $data .= "dns-search=" . join(';', PVE::Tools::split_list($searchdomains)) . "\n"
if $searchdomains;
}
} else {
@@ -271,7 +271,7 @@ sub setup_network_with_networkmanager {
}
if (@name_servers_v6) {
$data .= "dns=" . join(';', @name_servers_v6) . "\n";
- $data .= "dns-search=" . join(' ', PVE::Tools::split_list($searchdomains)) . "\n"
+ $data .= "dns-search=" . join(';', PVE::Tools::split_list($searchdomains)) . "\n"
if $searchdomains;
}
} else {
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
reply other threads:[~2025-12-30 12:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230125535.130173-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.