all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 3/7] remote tasks: remove unneeded enclosing Ok() and ?
Date: Mon, 29 Dec 2025 17:18:38 +0100	[thread overview]
Message-ID: <20251229161844.49433-4-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20251229161844.49433-1-m.sandoval@proxmox.com>

This was triggering the needless_question_mark clippy warning.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs
index c71a0894..435fd887 100644
--- a/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs
+++ b/server/src/bin/proxmox-datacenter-api/tasks/remote_tasks.rs
@@ -405,7 +405,7 @@ async fn apply_journal(cache: TaskCache) -> Result<(), Error> {
 
 /// Get a list of active tasks.
 async fn get_active_tasks(cache: TaskCache) -> Result<Vec<RemoteUpid>, Error> {
-    Ok(tokio::task::spawn_blocking(move || {
+    tokio::task::spawn_blocking(move || {
         let tasks: Vec<RemoteUpid> = cache
             .read()?
             .get_tasks(GetTasks::Active)?
@@ -414,7 +414,7 @@ async fn get_active_tasks(cache: TaskCache) -> Result<Vec<RemoteUpid>, Error> {
 
         Ok::<Vec<RemoteUpid>, Error>(tasks)
     })
-    .await??)
+    .await?
 }
 
 #[derive(PartialEq, Debug)]
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-12-29 16:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29 16:18 [pdm-devel] [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90 Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/7] remove needless borrows Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/7] simplify if-else block Maximiliano Sandoval
2025-12-29 16:18 ` Maximiliano Sandoval [this message]
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 4/7] firewall: prefer is_some_and over map_or false Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 5/7] subscription: remove unneeded return statement Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 6/7] api: resources: collapse identical if blocks Maximiliano Sandoval
2025-12-29 16:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 7/7] api: resources: rewrite let-else block with ? Maximiliano Sandoval
2025-12-30  9:18 ` [pdm-devel] partially-applied: [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90 Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251229161844.49433-4-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal