all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-yew-comp v2] task description: use hyphen (-) between the id and the action
Date: Fri, 19 Dec 2025 13:40:31 +0100	[thread overview]
Message-ID: <20251219124031.223144-1-l.wagner@proxmox.com> (raw)

This way it matches the way we render task descriptions in the JS code.
For instance, PBS GC tasks are now rendered as

"Datastore store2 - Garbage Collect"

instead of

"Datastore store2 Garbage Collect"

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
Changes since v1:
  - rebased to latest master

 src/utils/task_descriptions.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/utils/task_descriptions.rs b/src/utils/task_descriptions.rs
index 0184edf..09156ed 100644
--- a/src/utils/task_descriptions.rs
+++ b/src/utils/task_descriptions.rs
@@ -32,7 +32,7 @@ impl<A: Display, B: Display> IntoTaskDescriptionRenderFn for (A, B) {
         let action = self.1.to_string();
         Box::new(move |_, id| {
             format!(
-                "{} {} {}",
+                "{} {} - {}",
                 task_type,
                 id.as_deref().unwrap_or("unknown"),
                 action
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


             reply	other threads:[~2025-12-19 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 12:40 Lukas Wagner [this message]
2025-12-19 12:51 ` [pdm-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251219124031.223144-1-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal