From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/3] config: fix OVMF typo in error message
Date: Fri, 19 Dec 2025 11:54:27 +0100 [thread overview]
Message-ID: <20251219105431.155671-2-c.heiss@proxmox.com> (raw)
In-Reply-To: <20251219105431.155671-1-c.heiss@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
As we translate that string in the UI (see also next patch), this can
lead to this error being untranslated in the UI in certain package
version combinations (i.e. newer qemu-server, older pve-manager).
Not sure if we consider something like that breaking though, at has
least no functional impact per se.
src/PVE/QemuConfig.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
index ad6ce6b0..844ed69a 100644
--- a/src/PVE/QemuConfig.pm
+++ b/src/PVE/QemuConfig.pm
@@ -194,7 +194,7 @@ sub get_backup_volumes {
if ($key =~ m/^efidisk/ && (!defined($conf->{bios}) || $conf->{bios} ne 'ovmf')) {
$included = 0;
- $reason = "efidisk but no OMVF BIOS";
+ $reason = "efidisk but no OVMF BIOS";
}
push @$return_volumes,
--
2.51.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-12-19 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 10:54 [pve-devel] [PATCH qemu-server/pve-{manager, storage} 0/3] fix OVMF typos Christoph Heiss
2025-12-19 10:54 ` Christoph Heiss [this message]
2025-12-19 10:54 ` [pve-devel] [PATCH manager 2/3] ui: utils: fix OVMF typo in error message translation Christoph Heiss
2025-12-19 10:54 ` [pve-devel] [PATCH storage 3/3] plugin: fix OVMF typo in subroutine documentation Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219105431.155671-2-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.