Re: [pve-devel] [PATCH pve-common v2 1/1] fix #7153: iproute2: consider bonds as physical bridge ports

[Stoiko Ivanov <s.ivanov@proxmox.com>]

As I ran into this issue today - I took the time to check this out a bit
closer.

It fixes the issue of bond's vanishing from the bridge behind a vlan-vnet
on a  non-vlan-aware bridge.

one opinionated nit inline:
On Tue, 16 Dec 2025 17:05:10 +0100
Stefan Hanreich <s.hanreich@proxmox.com> wrote:

> The new check did not consider bonds, since ip_link_is_physical only
> returns true for physical interfaces - but not bonds. Add a new
> function to check for bonds explicitly and use it when checking for
> bridge ports in activate_bridge_vlan.
> 
> This bug caused VMs with network devices with VLAN tags, on
> non-vlan-aware bridges, to not get started / migrated.
> 
> Fixes: 057f62f7
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Changes from v1:
> * improved commit message
> * add missing definedness check
> 
>  src/PVE/IPRoute2.pm | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
> index 5208d93..c60a91d 100644
> --- a/src/PVE/IPRoute2.pm
> +++ b/src/PVE/IPRoute2.pm
> @@ -32,6 +32,14 @@ sub ip_link_is_physical($ip_link) {
>          && (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
>  }
>  
> +sub ip_link_is_bond($ip_link) {
> +    return
> +        $ip_link->{link_type} eq 'ether'
> +        && defined($ip_link->{linkinfo})
> +        && defined($ip_link->{linkinfo}->{info_kind})
> +        && $ip_link->{linkinfo}->{info_kind} eq 'bond';
> +}
> +
>  sub ip_link_is_bridge($ip_link) {
>      return
>          defined($ip_link->{linkinfo})
> @@ -67,7 +75,8 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
>      }
not sure if a bond is a "physical" bridge-port, and not sure if this might
cause confusion in the future - maybe non_guest_bridge_port?,
egress_bridge_port?

but as it's just a cosmetic fix (if an improvement at all)- the patch as is
is fine! consider this:
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
>  
>      return grep {
> -        ip_link_is_physical($ip_links->{$_}) && $ip_links->{$_}->{master} eq $bridge
> +        (ip_link_is_physical($ip_links->{$_}) || ip_link_is_bond($ip_links->{$_}))
> +            && defined($ip_links->{$_}->{master}) && $ip_links->{$_}->{master} eq $bridge
>      } keys $ip_links->%*;
>  }
>  



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel