From: Hannes Laimer <h.laimer@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH proxmox-yew-comp 1/1] firewall: rules: rename ListFirewallRules to FirewallRule
Date: Wed, 17 Dec 2025 16:08:31 +0100 [thread overview]
Message-ID: <20251217150831.199100-5-h.laimer@proxmox.com> (raw)
In-Reply-To: <20251217150831.199100-1-h.laimer@proxmox.com>
Adjust to rename in pve-api-types.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/firewall/rules.rs | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/firewall/rules.rs b/src/firewall/rules.rs
index 0958fc0..c40fab7 100644
--- a/src/firewall/rules.rs
+++ b/src/firewall/rules.rs
@@ -82,10 +82,10 @@ pub enum FirewallMsg {
#[doc(hidden)]
pub struct ProxmoxFirewallRules {
- store: Store<pve_api_types::ListFirewallRules>,
- loader: Loader<Vec<pve_api_types::ListFirewallRules>>,
- _listener: SharedStateObserver<LoaderState<Vec<pve_api_types::ListFirewallRules>>>,
- columns: Rc<Vec<DataTableHeader<pve_api_types::ListFirewallRules>>>,
+ store: Store<pve_api_types::FirewallRule>,
+ loader: Loader<Vec<pve_api_types::FirewallRule>>,
+ _listener: SharedStateObserver<LoaderState<Vec<pve_api_types::FirewallRule>>>,
+ columns: Rc<Vec<DataTableHeader<pve_api_types::FirewallRule>>>,
}
fn pill(text: impl Into<AttrValue>) -> Container {
@@ -99,7 +99,7 @@ fn pill(text: impl Into<AttrValue>) -> Container {
.with_child(text.into())
}
-fn format_firewall_rule(rule: &pve_api_types::ListFirewallRules) -> Html {
+fn format_firewall_rule(rule: &pve_api_types::FirewallRule) -> Html {
let mut parts: Vec<VNode> = Vec::new();
if let Some(iface) = &rule.iface {
@@ -155,21 +155,21 @@ impl ProxmoxFirewallRules {
}
}
- fn build_columns() -> Rc<Vec<DataTableHeader<pve_api_types::ListFirewallRules>>> {
+ fn build_columns() -> Rc<Vec<DataTableHeader<pve_api_types::FirewallRule>>> {
Rc::new(vec![
DataTableColumn::new("")
.width("30px")
.justify("right")
.show_menu(false)
.resizable(false)
- .render(|rule: &pve_api_types::ListFirewallRules| html! {&rule.pos})
+ .render(|rule: &pve_api_types::FirewallRule| html! {&rule.pos})
.into(),
DataTableColumn::new(tr!("On"))
.width("40px")
.justify("center")
.resizable(false)
.render(
- |rule: &pve_api_types::ListFirewallRules| match rule.enable {
+ |rule: &pve_api_types::FirewallRule| match rule.enable {
Some(1) => Fa::new("check").into(),
Some(0) | None => Fa::new("minus").into(),
_ => "-".into(),
@@ -178,19 +178,19 @@ impl ProxmoxFirewallRules {
.into(),
DataTableColumn::new(tr!("Type"))
.width("80px")
- .render(|rule: &pve_api_types::ListFirewallRules| html! {&rule.ty})
+ .render(|rule: &pve_api_types::FirewallRule| html! {&rule.ty})
.into(),
DataTableColumn::new(tr!("Action"))
.width("100px")
- .render(|rule: &pve_api_types::ListFirewallRules| html! {&rule.action})
+ .render(|rule: &pve_api_types::FirewallRule| html! {&rule.action})
.into(),
DataTableColumn::new(tr!("Rule"))
.flex(1)
- .render(|rule: &pve_api_types::ListFirewallRules| format_firewall_rule(rule))
+ .render(|rule: &pve_api_types::FirewallRule| format_firewall_rule(rule))
.into(),
DataTableColumn::new(tr!("Comment"))
.width("150px")
- .render(|rule: &pve_api_types::ListFirewallRules| {
+ .render(|rule: &pve_api_types::FirewallRule| {
rule.comment.as_deref().unwrap_or("-").into()
})
.into(),
@@ -207,7 +207,7 @@ impl Component for ProxmoxFirewallRules {
let url: AttrValue = props.context.rules_url().into();
- let store = Store::with_extract_key(|item: &pve_api_types::ListFirewallRules| {
+ let store = Store::with_extract_key(|item: &pve_api_types::FirewallRule| {
Key::from(item.pos.to_string())
});
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-17 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 15:08 [pdm-devel] [PATCH proxmox{, -datacenter-manager, -yew-comp} 0/4] " Hannes Laimer
2025-12-17 15:08 ` [pdm-devel] [PATCH proxmox 1/2] pve-api-types: " Hannes Laimer
2025-12-17 15:08 ` [pdm-devel] [PATCH proxmox 2/2] pve-api-types: regenerate Hannes Laimer
2025-12-17 15:08 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/1] pdm: rename ListFirewallRules to FirewallRule Hannes Laimer
2025-12-17 15:08 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217150831.199100-5-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.