From: Shannon Sterz <s.sterz@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager] ui: resource tree: name all columns and make them translatable
Date: Tue, 16 Dec 2025 16:52:54 +0100 [thread overview]
Message-ID: <20251216155253.378307-2-s.sterz@proxmox.com> (raw)
not giving a column a name leads to bad UX when editing the currently
visible columns of a table. the menu will then render a checkbox with
an empty label which may appear confusing.
additionally, make all column headers of the table translatable.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
ui/src/widget/resource_tree.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/src/widget/resource_tree.rs b/ui/src/widget/resource_tree.rs
index c7d6e67..ba178b8 100644
--- a/ui/src/widget/resource_tree.rs
+++ b/ui/src/widget/resource_tree.rs
@@ -414,7 +414,7 @@ fn columns(
.into()
})
.into(),
- DataTableColumn::new("Node")
+ DataTableColumn::new(tr!("Node"))
.width("150px")
.render(|item: &PdmTreeEntry| {
match item {
@@ -427,7 +427,7 @@ fn columns(
.into()
})
.into(),
- DataTableColumn::new("")
+ DataTableColumn::new(tr!("UI"))
.width("50px")
.justify("right")
.render({
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-12-16 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 15:52 Shannon Sterz [this message]
2025-12-17 10:01 ` [pdm-devel] applied: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216155253.378307-2-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.