[pve-devel] [PATCH firewall/manager/proxmox{-ve-rs, -firewall} 0/5] fix #7068: show rule comments in iptables and nftables

[Robert Obkircher <r.obkircher@proxmox.com>]

Pass firewall rule comments from the UI to the underlying firewall
configuration.

Combines and changes two previously separate patches:
New:
    - added a preserve_comments firewall option to api and UI
[1] fix #7068: show rule comments in iptables output
    - shortened PVECOMMENT: prefix to PVE:
    - fixed escape logic regex
    - added tests for print_ipt_command function
[2] fix #7068: show rule comments in nftables output
    - test truncation logic

Note that for testing you likely want the fix for '#' symbols inside
comments [3] and the fix for "make check" in pve-firewall [4].

At some point I ran into a strange issue, where the options grid
displayed "Yes" for boolean options which were clearly 0 in the network
response, while the edit dialog displayed the correct value. I'm not
sure what caused this but system updates and rebuilding pve-firewall
+pve-manager fixed it.

[1] https://lore.proxmox.com/pve-devel/20251201123424.94742-1-r.obkircher@proxmox.com/#r
[2] https://lore.proxmox.com/pve-devel/75f887c2-fce6-444e-829c-977784dca365@proxmox.com/#r
[3] https://lore.proxmox.com/pve-devel/20251215123925.168475-1-r.obkircher@proxmox.com/T/#u
[4] https://lore.proxmox.com/pve-devel/20251211141201.143435-1-r.obkircher@proxmox.com/

*** MURPP HERE ***

pve-firewall:

Robert Obkircher (2):
  api: firewall: add option to preserve comments
  fix #7068: show rule comments in iptables output

 src/PVE/Firewall.pm   | 36 +++++++++++++++++-
 test/Makefile         |  1 +
 test/test_comments.pl | 86 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 121 insertions(+), 2 deletions(-)
 create mode 100755 test/test_comments.pl


pve-manager:

Robert Obkircher (1):
  ui: firewall: add preserve comments option

 www/manager6/grid/FirewallOptions.js | 1 +
 1 file changed, 1 insertion(+)


proxmox-ve-rs:

Robert Obkircher (1):
  firewall: parse preserve_comments host firewall option

 proxmox-ve-config/src/firewall/host.rs | 14 ++++++++++++++
 1 file changed, 14 insertions(+)


proxmox-firewall:

Robert Obkircher (2):
  fix #7068: show rule comments in nftables output
  firewall: add rule comments to snapshot tests

 proxmox-firewall/src/rule.rs                  | 56 ++++++++++++++++++-
 proxmox-firewall/tests/input/host.fw          |  4 +-
 .../integration_tests__firewall.snap          | 44 ++++++++++++++-
 3 files changed, 100 insertions(+), 4 deletions(-)


Summary over all repositories:
  8 files changed, 236 insertions(+), 6 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel