From: Shan Shaji <s.shaji@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager v2 6/6] cli: admin: add `delete-token` option to delete token from remote
Date: Wed, 10 Dec 2025 17:37:35 +0100 [thread overview]
Message-ID: <20251210163736.384795-7-s.shaji@proxmox.com> (raw)
In-Reply-To: <20251210163736.384795-1-s.shaji@proxmox.com>
Inorder to allow deleting the remote API token from PDM, added optional
boolean flag.
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
**note**: This patch was not included in v1 and was never reviewed.
cli/admin/src/remotes.rs | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/cli/admin/src/remotes.rs b/cli/admin/src/remotes.rs
index d1a3ede..b28bdd5 100644
--- a/cli/admin/src/remotes.rs
+++ b/cli/admin/src/remotes.rs
@@ -217,16 +217,28 @@ fn update_remote(
input: {
properties: {
id: { schema: REMOTE_ID_SCHEMA },
+ "delete-token": {
+ type: bool,
+ optional: true,
+ description: "Remove the API-Token from remote."
+ }
}
}
)]
-/// Add a new remote.
-fn remove_remote(id: String, rpcenv: &mut dyn RpcEnvironment) -> Result<(), Error> {
- let param = json!({ "id": id });
+/// Remove a new remote.
+async fn remove_remote(
+ id: String,
+ delete_token: Option<bool>,
+ rpcenv: &mut dyn RpcEnvironment,
+) -> Result<(), Error> {
+ let mut param = json!({ "id": id });
+ if delete_token.is_some() {
+ param["delete-token"] = delete_token.into();
+ }
let info = &dc_api::remotes::API_METHOD_REMOVE_REMOTE;
match info.handler {
- ApiHandler::Sync(handler) => (handler)(param, info, rpcenv).map(drop),
+ ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await.map(drop),
_ => unreachable!(),
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-10 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 16:37 [pdm-devel] [PATCH datacenter-manager/proxmox v2 0/7] fix #6914: add option to remove already existing token Shan Shaji
2025-12-10 16:37 ` [pdm-devel] [PATCH datacenter-manager v2 1/6] server: pbs-client: add delete admin token method Shan Shaji
2025-12-10 16:37 ` [pdm-devel] [PATCH datacenter-manager v2 2/6] server: api: add support to optionally delete token from remote Shan Shaji
2025-12-10 16:37 ` [pdm-devel] [PATCH datacenter-manager v2 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2025-12-10 16:37 ` [pdm-devel] [PATCH datacenter-manager v2 4/6] cli: client: add `delete-token` option to delete token from remote Shan Shaji
2025-12-10 16:37 ` [pdm-devel] [PATCH datacenter-manager v2 5/6] fix: ui: add remove confirmation dialog with optional token deletion Shan Shaji
2025-12-10 16:37 ` Shan Shaji [this message]
2025-12-10 16:37 ` [pdm-devel] [PATCH proxmox v2 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210163736.384795-7-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.