From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v3 qemu-server 0/2] dbus-vmstate: fix method call on dbus object resolving to wrong instance
Date: Wed, 10 Dec 2025 13:57:06 +0100 [thread overview]
Message-ID: <20251210125724.121834-1-f.ebner@proxmox.com> (raw)
Changes in v3:
* split patch
* replace dbus_get_property() with a wrapper around dbus_call_method()
Similar to the dbus_get_property(), calling methods on a dbus object
also needs to be done with care to respect the owner when there are
multiple instances. This was not done for the 'Quit' method when
migrating leading to crashes with unlucky timing.
Fiona Ebner (2):
dbus-vmstate: introduce dbus_call_method() helper
dbus-vmstate: fix method call on dbus object resolving to wrong
instance
src/PVE/QemuServer/DBusVMState.pm | 42 ++++++++++++++++++++-----------
1 file changed, 28 insertions(+), 14 deletions(-)
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-12-10 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 12:57 Fiona Ebner [this message]
2025-12-10 12:57 ` [pve-devel] [PATCH v3 qemu-server 1/2] dbus-vmstate: introduce dbus_call_method() helper Fiona Ebner
2025-12-10 12:57 ` [pve-devel] [PATCH v3 qemu-server 2/2] dbus-vmstate: fix method call on dbus object resolving to wrong instance Fiona Ebner
2025-12-10 13:28 ` [pve-devel] [PATCH v3 qemu-server 3/3] migrate: remove left-over dbus-vmstate instance when migrating without conntrack state Fiona Ebner
2025-12-10 13:31 ` Fiona Ebner
2025-12-10 14:35 ` [pve-devel] applied: [PATCH-SERIES v3 qemu-server 0/2] dbus-vmstate: fix method call on dbus object resolving to wrong instance Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210125724.121834-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.