[pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87

[pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87

[Maximiliano Sandoval]

proxmox-fixed-string uses std::str::from_utf8_unchecked which was
stabilized on 1.87, see its announcement [1].

[1] https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

A handful of clippy fixed spooted with:

    cargo clippy --all-targets --workspace --all-features


 Cargo.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Cargo.toml b/Cargo.toml
index 27a69afa..1f80a3a8 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -74,7 +74,7 @@ license = "AGPL-3"
 repository = "https://git.proxmox.com/?p=proxmox.git"
 homepage = "https://proxmox.com"
 exclude = [ "debian" ]
-rust-version = "1.82"
+rust-version = "1.87"
 
 [workspace.dependencies]
 # any features enabled here are enabled on all members using 'workspace = true'!
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 2/8] don't hide a lifetimes that are elided elsewhere

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-acme/src/account.rs               | 2 +-
 proxmox-notify/src/endpoints/smtp.rs      | 2 +-
 proxmox-sys/src/fs/acl.rs                 | 2 +-
 proxmox-sys/src/fs/read_dir.rs            | 2 +-
 proxmox-sys/src/linux/procfs/mountinfo.rs | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/proxmox-acme/src/account.rs b/proxmox-acme/src/account.rs
index 0bbf0027..f763c1e9 100644
--- a/proxmox-acme/src/account.rs
+++ b/proxmox-acme/src/account.rs
@@ -245,7 +245,7 @@ impl Account {
         &self,
         certificate: &[u8],
         reason: Option<u32>,
-    ) -> Result<CertificateRevocation, Error> {
+    ) -> Result<CertificateRevocation<'_>, Error> {
         let cert = if certificate.starts_with(b"-----BEGIN CERTIFICATE-----") {
             b64u::encode(&openssl::x509::X509::from_pem(certificate)?.to_der()?)
         } else {
diff --git a/proxmox-notify/src/endpoints/smtp.rs b/proxmox-notify/src/endpoints/smtp.rs
index d4fed237..c888dee7 100644
--- a/proxmox-notify/src/endpoints/smtp.rs
+++ b/proxmox-notify/src/endpoints/smtp.rs
@@ -381,7 +381,7 @@ fn build_forwarded_message(
 }
 
 /// Quote mail name if required by RFC5322.
-fn quote_name_if_needed(name: &str) -> Cow<str> {
+fn quote_name_if_needed(name: &str) -> Cow<'_, str> {
     // See https://datatracker.ietf.org/doc/html/rfc5322#section-3.2.3
     let needs_quotes = name.chars().any(|c| {
         matches!(
diff --git a/proxmox-sys/src/fs/acl.rs b/proxmox-sys/src/fs/acl.rs
index 29aa75ab..4aabb454 100644
--- a/proxmox-sys/src/fs/acl.rs
+++ b/proxmox-sys/src/fs/acl.rs
@@ -126,7 +126,7 @@ impl ACL {
         Ok(ACL { ptr })
     }
 
-    pub fn create_entry(&mut self) -> Result<ACLEntry, nix::errno::Errno> {
+    pub fn create_entry(&mut self) -> Result<ACLEntry<'_>, nix::errno::Errno> {
         let mut ptr = ptr::null_mut();
         let res = unsafe { acl_create_entry(&mut self.ptr, &mut ptr) };
         if res < 0 {
diff --git a/proxmox-sys/src/fs/read_dir.rs b/proxmox-sys/src/fs/read_dir.rs
index 66b6c838..d8330cd1 100644
--- a/proxmox-sys/src/fs/read_dir.rs
+++ b/proxmox-sys/src/fs/read_dir.rs
@@ -171,7 +171,7 @@ where
 
     /// Filter by file name. Note that file names which aren't valid utf-8 will be treated as if
     /// they do not match the pattern.
-    fn filter_file_name_regex(self, regex: &Regex) -> FileNameRegexFilter<Self, T, E> {
+    fn filter_file_name_regex(self, regex: &Regex) -> FileNameRegexFilter<'_, Self, T, E> {
         FileNameRegexFilter { inner: self, regex }
     }
 }
diff --git a/proxmox-sys/src/linux/procfs/mountinfo.rs b/proxmox-sys/src/linux/procfs/mountinfo.rs
index f02c314c..6cedbb84 100644
--- a/proxmox-sys/src/linux/procfs/mountinfo.rs
+++ b/proxmox-sys/src/linux/procfs/mountinfo.rs
@@ -211,7 +211,7 @@ impl MountInfo {
     }
 
     /// Iterate over mount entries.
-    pub fn iter(&self) -> Iter {
+    pub fn iter(&self) -> Iter<'_> {
         self.entries.iter()
     }
 
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 3/8] auth-api: remove unnecessary return

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-auth-api/src/api/access.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-auth-api/src/api/access.rs b/proxmox-auth-api/src/api/access.rs
index 3ff1d0e8..fe416250 100644
--- a/proxmox-auth-api/src/api/access.rs
+++ b/proxmox-auth-api/src/api/access.rs
@@ -93,7 +93,7 @@ pub async fn verify_vnc_ticket(verify_params: VerifyVNCTicket) -> Result<(), Err
         verify_params.port.unwrap_or_default(),
     )? {
         None => bail!("Checking VNC ticket failed"), // no path based tickets supported, just fall through.
-        Some(true) => return Ok(()),
+        Some(true) => Ok(()),
         Some(false) => bail!("No such privilege"),
     }
 }
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 4/8] deb-version: remove unnecesary vec! call

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-deb-version/src/lib.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-deb-version/src/lib.rs b/proxmox-deb-version/src/lib.rs
index e17c0441..9a51e799 100644
--- a/proxmox-deb-version/src/lib.rs
+++ b/proxmox-deb-version/src/lib.rs
@@ -477,7 +477,7 @@ mod tests {
     #[test]
     fn test_manpage_tilde_sequence() {
         // from deb-version manpage: ~~, ~~a, ~, (empty), a are in sorted order
-        let versions = vec!["~~", "~~a", "~", "", "a"];
+        let versions = ["~~", "~~a", "~", "", "a"];
         for i in 0..versions.len() - 1 {
             let result = debian_cmp_str(versions[i], versions[i + 1]);
             assert_eq!(
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 5/8] fixed-string: remove unused import

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-fixed-string/src/lib.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/proxmox-fixed-string/src/lib.rs b/proxmox-fixed-string/src/lib.rs
index 591ac91e..47af54ad 100644
--- a/proxmox-fixed-string/src/lib.rs
+++ b/proxmox-fixed-string/src/lib.rs
@@ -224,8 +224,6 @@ impl<'de> Deserialize<'de> for FixedString {
 mod tests {
     use super::*;
 
-    use serde_plain;
-
     #[test]
     fn test_construct() {
         let fixed_string = FixedString::new("").expect("empty string is valid");
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 6/8] rest-server: remove unused import

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-rest-server/src/rest.rs | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/proxmox-rest-server/src/rest.rs b/proxmox-rest-server/src/rest.rs
index d3e8475a..96ea406b 100644
--- a/proxmox-rest-server/src/rest.rs
+++ b/proxmox-rest-server/src/rest.rs
@@ -30,9 +30,7 @@ use url::form_urlencoded;
 
 use proxmox_http::Body;
 #[cfg(feature = "rate-limited-stream")]
-use proxmox_http::{RateLimiterTag, RateLimiterTags, RateLimiterTagsHandle};
-#[cfg(not(feature = "rate-limited-stream"))]
-type RateLimiterTags = ();
+use proxmox_http::{RateLimiterTag, RateLimiterTagsHandle};
 #[cfg(not(feature = "rate-limited-stream"))]
 type RateLimiterTagsHandle = ();
 use proxmox_router::{
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 7/8] http: remove unnecessary conversion

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-http/src/websocket/mod.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-http/src/websocket/mod.rs b/proxmox-http/src/websocket/mod.rs
index 4bf47eb2..5ce53651 100644
--- a/proxmox-http/src/websocket/mod.rs
+++ b/proxmox-http/src/websocket/mod.rs
@@ -880,11 +880,11 @@ impl WebSocket {
         select! {
             res = downstream_future.fuse() => match res {
                 Ok(_) => Ok(()),
-                Err(err) => Err(Error::from(err)),
+                Err(err) => Err(err),
             },
             res = upstream_future.fuse() => match res {
                 Ok(_) => Ok(()),
-                Err(err) => Err(Error::from(err)),
+                Err(err) => Err(err),
             },
         }
     }
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] [PATCH proxmox 8/8] router: replace clone with std::slice::from_ref

[Maximiliano Sandoval]

This does not clone nor copy.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxmox-router/src/cli/completion.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-router/src/cli/completion.rs b/proxmox-router/src/cli/completion.rs
index 091463de..2569f9a8 100644
--- a/proxmox-router/src/cli/completion.rs
+++ b/proxmox-router/src/cli/completion.rs
@@ -484,7 +484,7 @@ impl CompletionParser {
             // with no arguments remaining, the final global argument could need completion:
             if let Some((option, argument)) = global_args.last() {
                 if let Some(completion) =
-                    self.try_complete_global_property(option, &[argument.clone()])
+                    self.try_complete_global_property(option, std::slice::from_ref(argument))
                 {
                     return Ok(GlobalArgs::Completed(completion));
                 }
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87

[Thomas Lamprecht]

Am 09.12.25 um 11:53 schrieb Maximiliano Sandoval:
> proxmox-fixed-string uses std::str::from_utf8_unchecked which was
> stabilized on 1.87, see its announcement [1].
> 
> [1] https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/

Shouldn't proxmox-fixed-string then get that msrv bump though?

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> A handful of clippy fixed spooted with:
> 
>     cargo clippy --all-targets --workspace --all-features
> 
> 
>  Cargo.toml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Cargo.toml b/Cargo.toml
> index 27a69afa..1f80a3a8 100644
> --- a/Cargo.toml
> +++ b/Cargo.toml
> @@ -74,7 +74,7 @@ license = "AGPL-3"
>  repository = "https://git.proxmox.com/?p=proxmox.git"
>  homepage = "https://proxmox.com"
>  exclude = [ "debian" ]
> -rust-version = "1.82"
> +rust-version = "1.87"
>  
>  [workspace.dependencies]
>  # any features enabled here are enabled on all members using 'workspace = true'!



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87

[Maximiliano Sandoval]

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> Am 09.12.25 um 11:53 schrieb Maximiliano Sandoval:
>> proxmox-fixed-string uses std::str::from_utf8_unchecked which was
>> stabilized on 1.87, see its announcement [1].
>> 
>> [1] https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/
>
> Shouldn't proxmox-fixed-string then get that msrv bump though?

We can do that, but then it becomes a bit unruly to manage a per crate
msrv. I'll send a patch doing that.


-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87

[Thomas Lamprecht]

Am 10.12.25 um 09:40 schrieb Maximiliano Sandoval:
> Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
> 
>> Am 09.12.25 um 11:53 schrieb Maximiliano Sandoval:
>>> proxmox-fixed-string uses std::str::from_utf8_unchecked which was
>>> stabilized on 1.87, see its announcement [1].
>>>
>>> [1] https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/
>>
>> Shouldn't proxmox-fixed-string then get that msrv bump though?
> 
> We can do that, but then it becomes a bit unruly to manage a per crate
> msrv. I'll send a patch doing that.

IMO having to manually track where a dependency that requires higher
msrv is used is *much* harder and error prone than declaring that relation
for where it's actually used. I.e., with your patch we're still missing
PDM, pve-rs, ...?

On the contrary, if you declare dependency info for proxmox-fixed-string,
then debcargo will automatically generate a d/control dependency relation
like:

 rustc:native (>= 1.87) <!nocheck>,

Thus everything using that as build-dependency will get ensure the
correct rustc version is installed for all users of that crate, not
just one.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] superseded: [PATCH proxmox 1/8] cargo: bump msrv to 1.87

[Maximiliano Sandoval]

Thomas Lamprecht <t.lamprecht@proxmox.com> writes:

> Am 10.12.25 um 09:40 schrieb Maximiliano Sandoval:
>> Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
>> 
>>> Am 09.12.25 um 11:53 schrieb Maximiliano Sandoval:
>>>> proxmox-fixed-string uses std::str::from_utf8_unchecked which was
>>>> stabilized on 1.87, see its announcement [1].
>>>>
>>>> [1] https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/
>>>
>>> Shouldn't proxmox-fixed-string then get that msrv bump though?
>> 
>> We can do that, but then it becomes a bit unruly to manage a per crate
>> msrv. I'll send a patch doing that.
>
> IMO having to manually track where a dependency that requires higher
> msrv is used is *much* harder and error prone than declaring that relation
> for where it's actually used. I.e., with your patch we're still missing
> PDM, pve-rs, ...?
>
> On the contrary, if you declare dependency info for proxmox-fixed-string,
> then debcargo will automatically generate a d/control dependency relation
> like:
>
>  rustc:native (>= 1.87) <!nocheck>,
>
> Thus everything using that as build-dependency will get ensure the
> correct rustc version is installed for all users of that crate, not
> just one.

Superseded-by: https://lore.proxmox.com/all/20251210105615.215532-1-m.sandoval@proxmox.com/

-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel