From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-storage v1 0/3] Improve mkpath Error Message in activate_storage
Date: Fri, 5 Dec 2025 16:43:53 +0100 [thread overview]
Message-ID: <20251205154404.446338-1-m.carrara@proxmox.com> (raw)
Noticed a thread in the forum[forum] today where a user ran into the
following error when configuring a new NFS storage:
"create storage failed: mkdir /path/to/mountpoint/: Permission denied at
/usr/share/perl5/PVE/Storage/Plugin.pm line 1919"
Since it seemed that the user couldn't really interpret the error
correctly, improve that particular part in the code and make the error
handling / messaging a bit nicer for end users there.
Patch 01 and 02 just adapt the surrounding code in preparation; patch 03
contains the improvement as well as additional details.
References
----------
[forum]: https://forum.proxmox.com/threads/bug-creating-nfs-volume-storage.177354/
Summary of Changes
------------------
Max R. Carrara (3):
plugin: use guard clause to reduce nesting
plugin: remove needless inequality check when creating content subdirs
plugin: improve error handling when creating a content subdir fails
src/PVE/Storage/Plugin.pm | 75 +++++++++++++++++++++++++--------------
1 file changed, 49 insertions(+), 26 deletions(-)
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-12-05 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 15:43 Max R. Carrara [this message]
2025-12-05 15:43 ` [pve-devel] [PATCH pve-storage v1 1/3] plugin: use guard clause to reduce nesting Max R. Carrara
2025-12-05 15:43 ` [pve-devel] [PATCH pve-storage v1 2/3] plugin: remove needless inequality check when creating content subdirs Max R. Carrara
2025-12-05 15:43 ` [pve-devel] [PATCH pve-storage v1 3/3] plugin: improve error handling when creating a content subdir fails Max R. Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205154404.446338-1-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.