all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 1/5] ui: pve: remove overview: allow line-breaks for long lines
Date: Thu,  4 Dec 2025 15:20:25 +0100	[thread overview]
Message-ID: <20251204142451.2992215-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251204142451.2992215-1-d.csapak@proxmox.com>

the last two status rows contain longer text than the rest, so it can
easily happen that those get too long for the widget and overflow.

To allow for the text to wrap (without modifying the StatusRow component
itself), wrap the text in a div that allows wrapping and has the right
alignment set.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/pve/remote_overview.rs | 58 +++++++++++++++++++++--------------
 1 file changed, 35 insertions(+), 23 deletions(-)

diff --git a/ui/src/pve/remote_overview.rs b/ui/src/pve/remote_overview.rs
index 2c26e7ed..e4521314 100644
--- a/ui/src/pve/remote_overview.rs
+++ b/ui/src/pve/remote_overview.rs
@@ -1,14 +1,14 @@
 use std::rc::Rc;
 
-use proxmox_yew_comp::Status;
+use proxmox_yew_comp::{Status, StatusRow};
 use yew::Properties;
 
 use proxmox_human_byte::HumanByte;
 use pwt::{
-    css::{AlignItems, FontStyle},
+    css::{AlignItems, FontStyle, TextAlign, WhiteSpace},
     prelude::*,
     props::WidgetBuilder,
-    widget::{error_message, Column, Fa, Panel, Row},
+    widget::{error_message, Column, Container, Fa, Panel, Row},
 };
 use pwt_macros::widget;
 
@@ -253,26 +253,38 @@ impl yew::Component for RemotePanelComp {
                         .with_child(Fa::new("pie-chart"))
                         .with_child(tr!("Allocation")),
                 )
-                .with_child(status_row_right_icon(
-                    tr! {"CPU Cores assigned"},
-                    "fa-cpu",
-                    tr!(
-                        "{0} running / {1} physical ({2} total configured)",
-                        status.guest_cores_running,
-                        status.max_cores,
-                        status.guest_cores,
-                    ),
-                ))
-                .with_child(status_row_right_icon(
-                    tr! {"Memory assigned"},
-                    "fa-memory",
-                    tr!(
-                        "{0} running / {1} physical ({2} total configured)",
-                        HumanByte::from(status.guest_memory_running),
-                        HumanByte::from(status.max_memory),
-                        HumanByte::from(status.guest_memory),
-                    ),
-                )),
+                .with_child(
+                    StatusRow::new(tr! {"CPU Cores assigned"})
+                        .icon_right(true)
+                        .icon_class("fa fa-cpu")
+                        .status(
+                            Container::new()
+                                .with_child(tr!(
+                                    "{0} running / {1} physical ({2} total configured)",
+                                    status.guest_cores_running,
+                                    status.max_cores,
+                                    status.guest_cores,
+                                ))
+                                .class(WhiteSpace::Normal)
+                                .class(TextAlign::Right),
+                        ),
+                )
+                .with_child(
+                    StatusRow::new(tr! {"Memory assigned"})
+                        .icon_right(true)
+                        .icon_class("fa fa-memory")
+                        .status(
+                            Container::new()
+                                .with_child(tr!(
+                                    "{0} running / {1} physical ({2} total configured)",
+                                    HumanByte::from(status.guest_memory_running),
+                                    HumanByte::from(status.max_memory),
+                                    HumanByte::from(status.guest_memory),
+                                ))
+                                .class(WhiteSpace::Normal)
+                                .class(TextAlign::Right),
+                        ),
+                ),
         };
 
         Panel::new()
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-12-04 14:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 14:20 [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Dominik Csapak
2025-12-04 14:20 ` Dominik Csapak [this message]
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 2/5] ui: remote updates: show progress on 'refresh all' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 3/5] ui: configuration: subscription: improve behavior on 'check' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: views: add message on empty layouts Dominik Csapak
2025-12-04 15:18   ` Lukas Wagner
2025-12-04 14:20 ` [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes Dominik Csapak
2025-12-04 15:21   ` Lukas Wagner
2025-12-04 20:01   ` Thomas Lamprecht
2025-12-05  7:35     ` Dominik Csapak
2025-12-04 15:23 ` [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Lukas Wagner
2025-12-04 20:01 ` [pdm-devel] partially-applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204142451.2992215-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal