[pdm-devel] [PATCH datacenter-manager 1/3] ui: views: node panel: improve wording for pbs nodes and defuse icon

[pdm-devel] [PATCH datacenter-manager 1/3] ui: views: node panel: improve wording for pbs nodes and defuse icon

[Dominik Csapak]

using a warning icon instead of an error one defuses this error a bit.
Also include the the total amount of pbs nodes in the error.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/dashboard/node_status_panel.rs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ui/src/dashboard/node_status_panel.rs b/ui/src/dashboard/node_status_panel.rs
index 1c37c8e3..a93e03a7 100644
--- a/ui/src/dashboard/node_status_panel.rs
+++ b/ui/src/dashboard/node_status_panel.rs
@@ -141,8 +141,11 @@ fn map_status(
                 tr!("{0} of an unknown number of nodes online", online),
             ),
             Some(RemoteType::Pbs) => (
-                Status::Error.into(),
-                tr!("{0} remotes failed", failed_remotes),
+                Status::Warning.into(),
+                tr!(
+                    "One of {0} nodes online" | "{n} of {0} nodes online" % *online,
+                    online + failed_remotes as u64
+                ),
             ),
         },
         NodeStatusCount { online, .. } => (Status::Success.into(), tr!("{0} nodes online", online)),
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 2/3] ui: views: remote panel: improve and defuse error for unreachable remotes

[Dominik Csapak]

split cases into:
* all failed
* more than 50% failed -> error
* less than 50% failed -> warning

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/dashboard/remote_panel.rs | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/ui/src/dashboard/remote_panel.rs b/ui/src/dashboard/remote_panel.rs
index 16125a9b..375e32ea 100644
--- a/ui/src/dashboard/remote_panel.rs
+++ b/ui/src/dashboard/remote_panel.rs
@@ -82,9 +82,27 @@ impl Component for PdmRemotePanel {
                 tr!("Could reach all remotes."),
                 false,
             ),
-            (failed, _) => (
+            (_, 0) => (
                 Fa::from(Status::Error),
-                tr!("Failed to reach one remote." | "Failed to reach {n} remotes." % failed),
+                tr!("Failed to reach all remotes"),
+                true,
+            ),
+            (failed, remotes) if failed > remotes => (
+                Fa::from(Status::Error),
+                tr!(
+                    "Failed to reach {0} out of {1} remotes",
+                    failed,
+                    failed + remotes
+                ),
+                true,
+            ),
+            (failed, remotes) => (
+                Fa::from(Status::Warning),
+                tr!(
+                    "Failed to reach one of {0} remotes."
+                        | "Failed to reach {n} of {0} remotes." % failed,
+                    failed + remotes
+                ),
                 true,
             ),
         };
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 3/3] ui: views: remote panel: center error text

[Dominik Csapak]

like we do on the node panels

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 ui/src/dashboard/remote_panel.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ui/src/dashboard/remote_panel.rs b/ui/src/dashboard/remote_panel.rs
index 375e32ea..dbd346af 100644
--- a/ui/src/dashboard/remote_panel.rs
+++ b/ui/src/dashboard/remote_panel.rs
@@ -122,7 +122,11 @@ impl Component for PdmRemotePanel {
             .style("cursor", failure.then_some("pointer"))
             .gap(2)
             .with_child(remote_icon.large_4x())
-            .with_child(Container::new().with_child(remote_text))
+            .with_child(
+                Container::new()
+                    .class(css::TextAlign::Center)
+                    .with_child(remote_text),
+            )
             .into()
     }
 }
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 1/3] ui: views: node panel: improve wording for pbs nodes and defuse icon

[Thomas Lamprecht]

On Wed, 03 Dec 2025 09:23:26 +0100, Dominik Csapak wrote:
> using a warning icon instead of an error one defuses this error a bit.
> Also include the the total amount of pbs nodes in the error.
> 
> 

Applied, thanks!

[1/3] ui: views: node panel: improve wording for pbs nodes and defuse icon
      commit: 2811b1b450068fa077e4671bcd7cca32b44b027f
[2/3] ui: views: remote panel: improve and defuse error for unreachable remotes
      commit: 844e4669044b0c912daf98bad4d0f957ff9ac23f
[3/3] ui: views: remote panel: center error text
      commit: c0d3244d2475045af7bd661c6b17de4809b43fc9


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel