From: Christian Ebner <c.ebner@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [RFC datacenter-manager] ui: rename PBS node slug to overview as stop-gap for search routing
Date: Tue, 2 Dec 2025 09:31:52 +0100 [thread overview]
Message-ID: <20251202083152.71130-1-c.ebner@proxmox.com> (raw)
This makes sure that the correct view is rendered when searching and
clicking on a PBS datastore while being on a panel not related to the
PBS remotes.
The search produces the correct path in navigate_to() when the
PdmResourceTree triggers Msg::NavigateToEntry, setting this via
the navigator(). The result is however still being the node status
view slug to be appended, which leads to datastores being displayed
incorrectly. By setting the slug to `overview`, it now works for both
cases.
This is intended as temporary stop-gap until the actual routing
behaviour is fixed.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Still unsure how the actual routing behaviour is, but it seems to be
related to the node status pushing the slug to the path somehow.
This seems to also depend on whether the node was selected first or
not.
Please ignore if you do not see this fitting as stop-gap.
ui/src/pbs/node/mod.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
index 2033bb1..e32c2c6 100644
--- a/ui/src/pbs/node/mod.rs
+++ b/ui/src/pbs/node/mod.rs
@@ -70,7 +70,7 @@ impl yew::Component for PbsNodePanelComp {
.class(ColorScheme::Neutral)
.with_item_builder(
TabBarItem::new()
- .key("status_view")
+ .key("overview")
.label(tr!("Overview"))
.icon_class("fa fa-tachometer"),
{
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next reply other threads:[~2025-12-02 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 8:31 Christian Ebner [this message]
2025-12-02 9:00 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202083152.71130-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.