From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH yew-comp v2 2/2] apt package manager: add optional subscription check on 'Refresh' button
Date: Mon, 1 Dec 2025 14:53:00 +0100 [thread overview]
Message-ID: <20251201135318.2983539-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20251201135318.2983539-1-d.csapak@proxmox.com>
but only if the 'subscription_url' is set on the component.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/apt_package_manager.rs | 63 ++++++++++++++++++++++++++++++++++++--
1 file changed, 60 insertions(+), 3 deletions(-)
diff --git a/src/apt_package_manager.rs b/src/apt_package_manager.rs
index d01f275..78e82a0 100644
--- a/src/apt_package_manager.rs
+++ b/src/apt_package_manager.rs
@@ -5,6 +5,7 @@ use std::pin::Pin;
use std::rc::Rc;
use anyhow::Error;
+use serde_json::Value;
use yew::html::IntoEventCallback;
use yew::html::IntoPropValue;
@@ -17,8 +18,11 @@ use pwt::widget::data_table::{
DataTable, DataTableCellRenderArgs, DataTableColumn, DataTableHeader, DataTableHeaderGroup,
};
use pwt::widget::{Button, Container, Toolbar, Tooltip};
+use pwt::AsyncPool;
use crate::percent_encoding::percent_encode_component;
+use crate::subscription_alert::subscription_is_active;
+use crate::SubscriptionAlert;
use crate::{
DataViewWindow, LoadableComponent, LoadableComponentContext, LoadableComponentMaster, XTermJs,
};
@@ -56,6 +60,11 @@ pub struct AptPackageManager {
#[prop_or_default]
#[builder_cb(IntoEventCallback, into_event_callback, ())]
pub on_upgrade: Option<Callback<()>>,
+
+ #[prop_or_default]
+ #[builder(IntoPropValue, into_prop_value)]
+ /// The base url for the subscription check
+ pub subscription_url: Option<AttrValue>,
}
impl Default for AptPackageManager {
@@ -142,12 +151,14 @@ fn update_list_to_tree(updates: &[APTUpdateInfo]) -> SlabTree<TreeEntry> {
#[derive(Clone, PartialEq)]
pub enum ViewState {
ShowChangelog(String),
+ ShowSubscriptionPopup,
}
pub struct ProxmoxAptPackageManager {
tree_store: TreeStore<TreeEntry>,
selection: Selection,
columns: Rc<Vec<DataTableHeader<TreeEntry>>>,
+ async_pool: AsyncPool,
}
impl LoadableComponent for ProxmoxAptPackageManager {
@@ -164,9 +175,33 @@ impl LoadableComponent for ProxmoxAptPackageManager {
tree_store,
selection,
columns,
+ async_pool: AsyncPool::new(),
}
}
+ fn update(&mut self, ctx: &LoadableComponentContext<Self>, _msg: Self::Message) -> bool {
+ let link = ctx.link().clone();
+ let props = ctx.props();
+ let url = props
+ .clone()
+ .subscription_url
+ .unwrap_or("/nodes/localhost/subscription".into());
+ let task_base_url = props.task_base_url.clone();
+ let command = format!("{}/update", props.base_url);
+ self.async_pool.spawn(async move {
+ let data = crate::http_get::<Value>(url.as_str(), None).await;
+ let is_active = subscription_is_active(&Some(data));
+
+ if is_active {
+ link.task_base_url(task_base_url);
+ link.start_task(&command, None, false);
+ } else {
+ link.change_view(Some(ViewState::ShowSubscriptionPopup));
+ }
+ });
+ true
+ }
+
fn load(
&self,
ctx: &LoadableComponentContext<Self>,
@@ -211,13 +246,20 @@ impl LoadableComponent for ProxmoxAptPackageManager {
.class("pwt-w-100")
.class("pwt-overflow-hidden")
.class("pwt-border-bottom")
- .with_child(Button::new(tr!("Refresh")).onclick({
+ .with_child(Button::new(tr!("Refresh")).on_activate({
let link = ctx.link();
-
+ let sub_check = props.subscription_url.is_some();
link.task_base_url(props.task_base_url.clone());
let command = format!("{}/update", props.base_url);
- move |_| link.start_task(&command, None, false)
+
+ move |_| {
+ if sub_check {
+ link.send_message(());
+ } else {
+ link.start_task(&command, None, false);
+ }
+ }
}))
.with_child(
Button::new(tr!("Upgrade"))
@@ -263,6 +305,21 @@ impl LoadableComponent for ProxmoxAptPackageManager {
ViewState::ShowChangelog(package) => {
Some(self.create_show_changelog_dialog(ctx, package))
}
+ ViewState::ShowSubscriptionPopup => {
+ let link = ctx.link().clone();
+ let props = ctx.props();
+ let task_base_url = props.task_base_url.clone();
+ let command = format!("{}/update", props.base_url);
+ Some(
+ SubscriptionAlert::new("notfound")
+ .on_close(move |_| {
+ link.change_view(None);
+ link.task_base_url(task_base_url.clone());
+ link.start_task(&command, None, false);
+ })
+ .into(),
+ )
+ }
}
}
--
2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-01 13:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 13:52 [pdm-devel] [PATCH datacenter-manager/yew-comp v2 00/11] add subscription checks to apt repository updates & login Dominik Csapak
2025-12-01 13:52 ` [pdm-devel] [PATCH yew-comp v2 1/2] subscription: refactor api subscription check for showing the alert Dominik Csapak
2025-12-01 19:02 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` Dominik Csapak [this message]
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 1/9] subscription: add serverid field to node subscription info Dominik Csapak
2025-12-01 23:01 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 2/9] api types: add new SubscriptionStatistics Dominik Csapak
2025-12-01 23:01 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 3/9] api: add subscription endpoints Dominik Csapak
2025-12-01 23:01 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 4/9] server: api: subscription: fix permission check Dominik Csapak
2025-12-01 23:01 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 5/9] server: api: pve/pbs: node: add subscription api call Dominik Csapak
2025-12-01 23:01 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 6/9] ui: pve/pbs: updates: add subscription_url Dominik Csapak
2025-12-01 23:01 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 7/9] ui: login: enable subscription check Dominik Csapak
2025-12-01 23:02 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 8/9] ui: refactor check_subscription into lib Dominik Csapak
2025-12-01 23:02 ` [pdm-devel] applied: " Thomas Lamprecht
2025-12-01 13:53 ` [pdm-devel] [PATCH datacenter-manager v2 9/9] ui: remote updates: add subscription check on 'Refresh all' Dominik Csapak
2025-12-01 23:02 ` [pdm-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201135318.2983539-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.